Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update DSP API Server cABundle error msg #529

Conversation

pgodowski
Copy link

The issue resolved by this Pull Request:

Resolves #528

Description of your changes:

Improves the error message to explicitly say which attribute to use in the CR to specify the CA Bundle for the self-signed / untrusted certificate for the Object Store.

Testing instructions

Setup the local Object Store (e.g. minio, see https://ai-on-openshift.io/tools-and-applications/minio/minio/) with the self-signed certificate and then attempt to use such Object Store as exernal Object Store. The error message should appear, indicating the exact attribute to use to specify the CA Bundle (should be spec.apiServer.cABundle).

Checklist

  • The commits are squashed in a cohesive manner and have meaningful messages.
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work

Signed-off-by: Piotr Godowski <piotr.godowski@pl.ibm.com>
@hbelmiro
Copy link
Contributor

hbelmiro commented Jan 3, 2024

/lgtm

@dsp-developers
Copy link
Contributor

A new image has been built to help with testing out this PR: quay.io/opendatahub/data-science-pipelines-operator:pr-529
An OCP cluster where you are logged in as cluster admin is required.

To use this image run the following:

cd $(mktemp -d)
git clone git@github.com:opendatahub-io/data-science-pipelines-operator.git
cd data-science-pipelines-operator/
git fetch origin pull/529/head
git checkout -b pullrequest 30bbcbc1ca4a66d1c297e125df24a8b1ee0d9942
make deploy IMG="quay.io/opendatahub/data-science-pipelines-operator:pr-529"

More instructions here on how to deploy and test a Data Science Pipelines Application.

Copy link
Member

@DharmitD DharmitD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/Approve

Copy link
Contributor

openshift-ci bot commented Jan 3, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: amadhusu, DharmitD, hbelmiro

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved label Jan 3, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit 3c0787b into opendatahub-io:main Jan 3, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants