-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove mcad.ibm.com APIGroup #530
Conversation
A new image has been built to help with testing out this PR: To use this image run the following: cd $(mktemp -d)
git clone git@github.com:opendatahub-io/data-science-pipelines-operator.git
cd data-science-pipelines-operator/
git fetch origin pull/530/head
git checkout -b pullrequest c6abbc3c9b483335f6f5960948a387ebcd843b13
make deploy IMG="quay.io/opendatahub/data-science-pipelines-operator:pr-530" More instructions here on how to deploy and test a Data Science Pipelines Application. |
The issue linked seems to be suggesting a missing permissions, the PR is removing more permissions so I doubt this resolves the issue above. @diegolovison can you please post the exact permission error you encountered. |
@sutaakar could you please review and ack this? |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: amadhusu, HumairAK, sutaakar The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Description of your changes:
The MCAD group seems to have been taken out of the codeflare-operator rbac. Updating DSPO RBCs to reflect the same and make the RBACs consistent.
Checklist