Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove mcad.ibm.com APIGroup #530

Merged
merged 1 commit into from
Jan 5, 2024
Merged

Remove mcad.ibm.com APIGroup #530

merged 1 commit into from
Jan 5, 2024

Conversation

DharmitD
Copy link
Member

@DharmitD DharmitD commented Jan 4, 2024

Description of your changes:

The MCAD group seems to have been taken out of the codeflare-operator rbac. Updating DSPO RBCs to reflect the same and make the RBACs consistent.

Checklist

  • The commits are squashed in a cohesive manner and have meaningful messages.
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work

@dsp-developers
Copy link
Contributor

A new image has been built to help with testing out this PR: quay.io/opendatahub/data-science-pipelines-operator:pr-530
An OCP cluster where you are logged in as cluster admin is required.

To use this image run the following:

cd $(mktemp -d)
git clone git@github.com:opendatahub-io/data-science-pipelines-operator.git
cd data-science-pipelines-operator/
git fetch origin pull/530/head
git checkout -b pullrequest c6abbc3c9b483335f6f5960948a387ebcd843b13
make deploy IMG="quay.io/opendatahub/data-science-pipelines-operator:pr-530"

More instructions here on how to deploy and test a Data Science Pipelines Application.

@HumairAK
Copy link
Contributor

HumairAK commented Jan 4, 2024

The issue linked seems to be suggesting a missing permissions, the PR is removing more permissions so I doubt this resolves the issue above.

@diegolovison can you please post the exact permission error you encountered.

@HumairAK HumairAK removed the lgtm label Jan 4, 2024
@DharmitD
Copy link
Member Author

DharmitD commented Jan 5, 2024

@sutaakar could you please review and ack this?

@HumairAK
Copy link
Contributor

HumairAK commented Jan 5, 2024

/approve

Copy link
Contributor

openshift-ci bot commented Jan 5, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: amadhusu, HumairAK, sutaakar

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved label Jan 5, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit 6991f3a into opendatahub-io:main Jan 5, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants