Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rm unused images #552

Merged
merged 3 commits into from
Jan 22, 2024
Merged

Rm unused images #552

merged 3 commits into from
Jan 22, 2024

Conversation

HumairAK
Copy link
Contributor

  • remove unused images, artifact/moveresultsimage/cache images are not used in argo dsp v2, they don't need to be part of the config
  • the dspo requeue time did not resolve because the var was not exposed
  • changed default argo namespace to opendatahub to complement the odh overlay install, reflected change in makefile default as well
  • updated tests to reflect change

Signed-off-by: Humair Khan <HumairAK@users.noreply.github.com>
Signed-off-by: Humair Khan <HumairAK@users.noreply.github.com>
Signed-off-by: Humair Khan <HumairAK@users.noreply.github.com>
Copy link
Contributor

openshift-ci bot commented Jan 22, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from humairak. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@dsp-developers
Copy link
Contributor

A new image has been built to help with testing out this PR: quay.io/opendatahub/data-science-pipelines-operator:pr-552
An OCP cluster where you are logged in as cluster admin is required.

To use this image run the following:

cd $(mktemp -d)
git clone git@github.com:opendatahub-io/data-science-pipelines-operator.git
cd data-science-pipelines-operator/
git fetch origin pull/552/head
git checkout -b pullrequest 2ec61f910235a727b9b1315466ea44caf28031c5
make deploy IMG="quay.io/opendatahub/data-science-pipelines-operator:pr-552"

More instructions here on how to deploy and test a Data Science Pipelines Application.

@HumairAK HumairAK merged commit de91e4d into opendatahub-io:main Jan 22, 2024
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants