Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix serving cert annotations #588

Merged

Conversation

gregsheremeta
Copy link
Contributor

Service serving certificate annotations were changed from alpha to beta 3 years ago. Fixing.

Ref: openshift/openshift-docs@847d4dc

Checklist

  • The commits are squashed in a cohesive manner and have meaningful messages.
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work

Service serving certificate annotations were changed from `alpha` to
`beta` 3 years ago. Fixing.

Ref: openshift/openshift-docs@847d4dc
@dsp-developers
Copy link
Contributor

A new image has been built to help with testing out this PR: quay.io/opendatahub/data-science-pipelines-operator:pr-588
An OCP cluster where you are logged in as cluster admin is required.

To use this image run the following:

cd $(mktemp -d)
git clone git@github.com:opendatahub-io/data-science-pipelines-operator.git
cd data-science-pipelines-operator/
git fetch origin pull/588/head
git checkout -b pullrequest 644ed044b411e7a8d83fa918a2946cfd5dc37955
oc new-project opendatahub
make deploy IMG="quay.io/opendatahub/data-science-pipelines-operator:pr-588"

More instructions here on how to deploy and test a Data Science Pipelines Application.

@HumairAK
Copy link
Contributor

HumairAK commented Mar 6, 2024

/lgtm
/approve

Copy link
Contributor

openshift-ci bot commented Mar 6, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: HumairAK

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved label Mar 6, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit 4325281 into opendatahub-io:main Mar 6, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants