Updated handling of dspa tls config

[VaniHaripriya]

The issue resolved by this Pull Request:

Resolves RHOAIENG-4384

Description of your changes:

Removed the string template for default value of DbExtraParams and created a struct to handle the tls config.

Testing instructions

• Use dspa_simple.yaml file to deploy dspa and create a pipeline run to verify if it runs properly.
• Use the following yaml to deploy dspa and create a pipeline run to verify if it runs properly. Before testing this please deploy an external maria-db in a different namespace in your cluster. The resources from here can be used to deploy the external DB.

apiVersion: datasciencepipelinesapplications.opendatahub.io/v1alpha1
kind: DataSciencePipelinesApplication
metadata:
  name: sample
spec:
  dspVersion: v2
  apiServer:
    deploy: true    
    enableSamplePipeline: true
  objectStorage:
    minio:
      deploy: true
      image: 'quay.io/opendatahub/minio:RELEASE.2019-08-14T20-37-41Z-license-compliance'
  database:
    customExtraParams: '{"tls":"false"}'
    externalDB:
      host: mariadb.test-mariadb.svc.cluster.local
      port: "3306"
      username: mlpipeline
      pipelineDBName: mlpipeline
      passwordSecret:
        name: ds-pipeline-db-test
        key: password
  mlpipelineUI:
    image: quay.io/opendatahub/ds-pipelines-frontend:latest

Checklist

• The commits are squashed in a cohesive manner and have meaningful messages.
• Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
• The developer has manually tested the changes and verified that the changes work

[dsp-developers]

A new image has been built to help with testing out this PR: quay.io/opendatahub/data-science-pipelines-operator:pr-620
An OCP cluster where you are logged in as cluster admin is required.

To use this image run the following:

cd $(mktemp -d)
git clone git@github.com:opendatahub-io/data-science-pipelines-operator.git
cd data-science-pipelines-operator/
git fetch origin pull/620/head
git checkout -b pullrequest a35f4452b3368b3ceb1a88270fc6c6cdabc4ed20
oc new-project opendatahub
make deploy IMG="quay.io/opendatahub/data-science-pipelines-operator:pr-620"

More instructions here on how to deploy and test a Data Science Pipelines Application.

[dsp-developers]

Change to PR detected. A new PR build was completed.
A new image has been built to help with testing out this PR: quay.io/opendatahub/data-science-pipelines-operator:pr-620

[amadhusu]

I was able to verify the first test case but the second test case with the provided yaml is failing as I believe there are more steps required which isn't mentioned in the Testing steps. I believe the pre-requisite for the second test case would be to have this said externaldb already present in the cluster maybe?

dspa_simple.yaml

second test case error

[VaniHaripriya]

I was able to verify the first test case but the second test case with the provided yaml is failing as I believe there are more steps required which isn't mentioned in the Testing steps. I believe the pre-requisite for the second test case would be to have this said externaldb already present in the cluster maybe?

dspa_simple.yaml
second test case error

@amadhusu Thank you for testing. I updated the testing instructions to deploy an external DB for the second test.

[dsp-developers]

Change to PR detected. A new PR build was completed.
A new image has been built to help with testing out this PR: quay.io/opendatahub/data-science-pipelines-operator:pr-620

[dsp-developers]

Change to PR detected. A new PR build was completed.
A new image has been built to help with testing out this PR: quay.io/opendatahub/data-science-pipelines-operator:pr-620

[dsp-developers]

Change to PR detected. A new PR build was completed.
A new image has been built to help with testing out this PR: quay.io/opendatahub/data-science-pipelines-operator:pr-620

[amadhusu]

Approving after all the requested changes.

[HumairAK]

/lgtm
/approve

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: amadhusu, HumairAK

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [HumairAK]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment