Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replaced Ginkgo and Gomega with Testify in functional tests #628

Merged
merged 2 commits into from
May 6, 2024

Conversation

hbelmiro
Copy link
Contributor

@hbelmiro hbelmiro commented Apr 17, 2024

The issue resolved by this Pull Request:

Resolves https://issues.redhat.com/browse/RHOAIENG-4261

Description of your changes:

Replaced Ginkgo and Gomega with Testify in functional tests

Testing instructions

Run make test. All tests must pass.

Checklist

  • The commits are squashed in a cohesive manner and have meaningful messages.
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work

@dsp-developers
Copy link
Contributor

A new image has been built to help with testing out this PR: quay.io/opendatahub/data-science-pipelines-operator:pr-628
An OCP cluster where you are logged in as cluster admin is required.

To use this image run the following:

cd $(mktemp -d)
git clone git@github.com:opendatahub-io/data-science-pipelines-operator.git
cd data-science-pipelines-operator/
git fetch origin pull/628/head
git checkout -b pullrequest 7ed99727f215de4fd1a0fb122b0e434f04b634e8
oc new-project opendatahub
make deploy IMG="quay.io/opendatahub/data-science-pipelines-operator:pr-628"

More instructions here on how to deploy and test a Data Science Pipelines Application.

@dsp-developers
Copy link
Contributor

Change to PR detected. A new PR build was completed.
A new image has been built to help with testing out this PR: quay.io/opendatahub/data-science-pipelines-operator:pr-628

@dsp-developers
Copy link
Contributor

Change to PR detected. A new PR build was completed.
A new image has been built to help with testing out this PR: quay.io/opendatahub/data-science-pipelines-operator:pr-628

@dsp-developers
Copy link
Contributor

Change to PR detected. A new PR build was completed.
A new image has been built to help with testing out this PR: quay.io/opendatahub/data-science-pipelines-operator:pr-628

@hbelmiro hbelmiro changed the title WIP - Replaced Ginkgo and Gomega with Testify in functional tests Replaced Ginkgo and Gomega with Testify in functional tests Apr 18, 2024
@hbelmiro hbelmiro marked this pull request as ready for review April 18, 2024 12:39
@DharmitD
Copy link
Member

@diegolovison can you also take a look, since you might need to update the related script that runs downstream. (I believe you should be good though since the Makefile command remains the same, but if you could just check and confirm)

controllers/suite_test.go Outdated Show resolved Hide resolved
go.mod Outdated Show resolved Hide resolved
Signed-off-by: hbelmiro <helber.belmiro@gmail.com>
Signed-off-by: hbelmiro <helber.belmiro@gmail.com>
@dsp-developers
Copy link
Contributor

Change to PR detected. A new PR build was completed.
A new image has been built to help with testing out this PR: quay.io/opendatahub/data-science-pipelines-operator:pr-628

Copy link
Member

@DharmitD DharmitD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@VaniHaripriya
Copy link
Contributor

Verified the tests in local. /lgtm

@HumairAK
Copy link
Contributor

HumairAK commented May 6, 2024

/approve

@HumairAK HumairAK merged commit 93da360 into opendatahub-io:main May 6, 2024
5 of 6 checks passed
Copy link
Contributor

openshift-ci bot commented May 6, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: HumairAK

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved label May 6, 2024
@hbelmiro hbelmiro deleted the RHOAIENG-4261 branch May 6, 2024 17:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants