Skip to content
This repository has been archived by the owner on Aug 2, 2022. It is now read-only.

Support for Kibana 7.0.1 #44

Merged
merged 7 commits into from
May 13, 2019
Merged

Support for Kibana 7.0.1 #44

merged 7 commits into from
May 13, 2019

Conversation

mihirsoni
Copy link
Contributor

@mihirsoni mihirsoni commented May 8, 2019

Issue #, if available: #43

Description of changes:
This PR enable support for Kibana 7.0.1

  • Updated configs
  • Updated aggregation to use .value
  • Update Update Monitor / Destinations with seq_no and primary_term
  • Updated breaking test cases
  • Support Dark mode (This needs to be read form the Global settings

dark-alerting

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@mihirsoni mihirsoni marked this pull request as ready for review May 9, 2019 20:44
Copy link
Contributor

@dbbaughe dbbaughe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks for changes

Copy link
Contributor

@ylwu-amzn ylwu-amzn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mihirsoni mihirsoni merged commit 7c9a51a into opendistro-for-elasticsearch:master May 13, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants