fix(host-devices): extend allowed major list #1740
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Extends major list with the Local/Experimental 240-254 range and 255 reserved. Signed-off-by: Tiago Castro <tiagolobocastro@gmail.com>
tiagolobocastro
requested review from
Abhinandan-Purkait,
abhilashshetty04 and
dsharma-dc
|
Resolves #1739 |
dsharma-dc
approved these changes
Sep 18, 2024
Abhinandan-Purkait
approved these changes
Sep 18, 2024
|
@tiagolobocastro Are we sure pools can be created on those devices? |
As long as it's a block device don't see why not. We're not stopping anyone today as we don't check this when creating the pool itself, it just changes the "available" reported on the plugin. |
|
bors merge |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extends major list with the Local/Experimental 240-254 range and 255 reserved.