Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add middleware to insert frontend moniroting script to response #415

Merged
merged 7 commits into from
May 22, 2024
Merged

feat: add middleware to insert frontend moniroting script to response #415

merged 7 commits into from
May 22, 2024

Conversation

iamsobanjaved
Copy link
Contributor

@iamsobanjaved iamsobanjaved commented May 20, 2024 •
edited
Loading

Description:

Add middleware to insert frontend monitoring scripts to response

Issue:

edx/edx-arch-experiments#639

Reviewers:

  • tag reviewer

Merge checklist:

  • All reviewers approved
  • CI build is green
  • Version bumped
  • Changelog record added
  • Documentation updated (not only docstrings)
  • Commits are squashed

Post merge:

  • Create a tag
  • Check new version is pushed to PyPi after tag-triggered build is
    finished.
  • Delete working branch (if not needed anymore)

Author concerns:

List any concerns about this PR - inelegant
solutions, hacks, quick-and-dirty implementations, concerns about
migrations, etc.

@iamsobanjaved iamsobanjaved force-pushed the iamsobanjaved/dd-rum-middleware branch 2 times, most recently from f4067e8 to 67e1728 Compare May 20, 2024 19:12
@iamsobanjaved iamsobanjaved linked an issue May 20, 2024 that may be closed by this pull request
[DD] Find solution for RUM of legacy Django template views edx/edx-arch-experiments#639
Closed
@iamsobanjaved iamsobanjaved mentioned this pull request May 20, 2024
Merged
@iamsobanjaved iamsobanjaved force-pushed the iamsobanjaved/dd-rum-middleware branch from 37a1685 to febd1b7 Compare May 20, 2024 20:32
@timmc-edx
Copy link
Contributor

Still reviewing, but could you go through the merge checklist in the PR template? (Version, changelog, anything else relevant.)

timmc-edx
timmc-edx reviewed May 21, 2024
View reviewed changes
Copy link
Contributor

@timmc-edx timmc-edx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some suggestions and questions but overall I think this is on the right track.

edx_django_utils/monitoring/internal/middleware.py Outdated Show resolved Hide resolved
edx_django_utils/monitoring/internal/middleware.py Outdated Show resolved Hide resolved
edx_django_utils/monitoring/internal/middleware.py Outdated Show resolved Hide resolved
edx_django_utils/monitoring/tests/test_middleware.py Outdated Show resolved Hide resolved
timmc-edx
timmc-edx approved these changes May 21, 2024
View reviewed changes
Copy link
Contributor

@timmc-edx timmc-edx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One comment issue, but otherwise looks good!

edx_django_utils/monitoring/internal/middleware.py Outdated Show resolved Hide resolved
@iamsobanjaved @timmc-edx
fix: update comment in code
7a858ab 
Co-authored-by: Tim McCormack <tmccormack@edx.org>
@iamsobanjaved iamsobanjaved merged commit bdc00e3 into master May 22, 2024
11 checks passed
@iamsobanjaved iamsobanjaved deleted the iamsobanjaved/dd-rum-middleware branch May 22, 2024 12:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timmc-edx timmc-edx timmc-edx approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[DD] Find solution for RUM of legacy Django template views
2 participants
@iamsobanjaved @timmc-edx