Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Create manual spans for monitoring backends. #435

Merged
merged 1 commit into from
Jul 30, 2024

Conversation

dianakhuang
Copy link
Contributor

@dianakhuang dianakhuang commented Jul 29, 2024

Ticket:
edx/edx-arch-experiments#658

Description:

This adds a new context manager for creating manual spans across our various backends. It adds in an interface for passing through arbitrary backend data because Datadog, New Relic, and OTEL all have different interfaces for creating these spans.

Merge checklist:

  • All reviewers approved
  • CI build is green
  • Version bumped
  • Changelog record added
  • Documentation updated (not only docstrings)
  • Commits are squashed

Post merge:

  • Create a tag
  • Check new version is pushed to PyPi after tag-triggered build is
    finished.
  • Delete working branch (if not needed anymore)

Author concerns:

@dianakhuang dianakhuang force-pushed the diana/create-manual-spans branch 4 times, most recently from cb1857f to cd0d76c Compare July 29, 2024 18:37
CHANGELOG.rst Outdated Show resolved Hide resolved
@dianakhuang dianakhuang force-pushed the diana/create-manual-spans branch 5 times, most recently from aa176dd to bb6b286 Compare July 30, 2024 15:42
@dianakhuang dianakhuang force-pushed the diana/create-manual-spans branch 2 times, most recently from 31b0e99 to 5e3e623 Compare July 30, 2024 19:06
@dianakhuang dianakhuang merged commit 704da9a into master Jul 30, 2024
11 of 13 checks passed
@dianakhuang dianakhuang deleted the diana/create-manual-spans branch July 30, 2024 19:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants