-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BOM-2849: Upgrade django-cors-headers to 3.9.0 #28846
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to go. You should add a doc link for the new github dependency format change (moving the eggname from the end of the url to start).
requirements/edx/base.txt
Outdated
@@ -1091,9 +1087,9 @@ xblock==1.5.1 | |||
# xblock-google-drive | |||
# xblock-poll | |||
# xblock-utils | |||
git+https://github.com/edx-solutions/xblock-drag-and-drop-v2@v2.3.5#egg=xblock-drag-and-drop-v2==2.3.5 | |||
xblock-drag-and-drop-v2 @ git+https://github.com/edx-solutions/xblock-drag-and-drop-v2@v2.3.5 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a change in the latest version of pip-tools where they started using direct reference instead of egg name.
https://github.com/jazzband/pip-tools/blob/master/CHANGELOG.md#630-2021-09-21
PR where changes were made
jazzband/pip-tools#1455
e373839
to
147e75b
Compare
Your PR has finished running tests. There were no failures. |
EdX Release Notice: This PR has been deployed to the staging environment in preparation for a release to production. |
EdX Release Notice: This PR has been deployed to the production environment. |
Relevant JIRA : https://openedx.atlassian.net/browse/BOM-2849
Following is the changelog for django-cors-headers post v3.5.0, It seems that we are good to go to the latest version.