Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: manually update pip-tools version to 6.5.1 to fix pip/pip-tools bug #160

Merged
merged 1 commit into from
Mar 29, 2022

Conversation

MichaelRoytman
Copy link
Contributor

The following comment is borrowed from this pull request, with changes: openedx/opaque-keys#218.

This failure started happening in the automated requirements upgrade GitHub action.

The bug was being caused by an interaction between pip and pip-tools, described here: jazzband/pip-tools#1558

The bug is fixed in pip-tools==6.5.0 - from this PR: jazzband/pip-tools#1567

This pull requests bumps the version of pip-tools manually to get the automated upgrades working again.

The following comment is borrowed from this pull request, with changes: openedx/opaque-keys#218

This failure started happening in the automated requirements upgrade GitHub action:
https://github.com/openedx/edx-submissions/runs/5704384647?check_suite_focus=true

The bug was being caused by an interaction between pip and pip-tools, described here: jazzband/pip-tools#1558

The bug is fixed in pip-tools==6.5.0 - from this pull request: jazzband/pip-tools#1567

This pull requests bumps the version of pip-tools manually to get the automated upgrades working again.
@MichaelRoytman MichaelRoytman force-pushed the mroytman/fix_pip_tools_for_pkg_upgrade branch from 265c7f4 to 094f558 Compare March 29, 2022 15:11
@codecov
Copy link

codecov bot commented Mar 29, 2022

Codecov Report

Merging #160 (094f558) into master (8510716) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #160   +/-   ##
=======================================
  Coverage   93.36%   93.36%           
=======================================
  Files          18       18           
  Lines        1975     1975           
  Branches      183      183           
=======================================
  Hits         1844     1844           
  Misses        118      118           
  Partials       13       13           
Flag Coverage Δ
unittests 93.36% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8510716...094f558. Read the comment docs.

@MichaelRoytman MichaelRoytman merged commit 09af161 into master Mar 29, 2022
@MichaelRoytman MichaelRoytman deleted the mroytman/fix_pip_tools_for_pkg_upgrade branch March 29, 2022 18:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants