Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: implented notification preference UI for cadence #1013

Merged
merged 6 commits into from
Mar 25, 2024

Conversation

ayesha-waris
Copy link
Contributor

@ayesha-waris ayesha-waris commented Mar 11, 2024

INF-1227
Description:

We now will have a new email setting related to email cadences.
Options for email cadence for a notification can be Daily, Weekly and Immediately.
Complete UI as shown in mockup

Uploading Screenshot 2024-03-14 at 2.00.43 PM.png…

Complete integration with BE to successfully update these email cadence settings

@ayesha-waris ayesha-waris marked this pull request as ready for review March 14, 2024 08:53
Copy link

codecov bot commented Mar 14, 2024

Codecov Report

Attention: Patch coverage is 85.50725% with 10 lines in your changes are missing coverage. Please review.

Project coverage is 56.79%. Comparing base (891e28e) to head (43bf2b1).
Report is 8 commits behind head on master.

Files Patch % Lines
...ation-preferences/NotificationPreferenceColumn.jsx 81.25% 5 Missing and 1 partial ⚠️
src/notification-preferences/NotificationTypes.jsx 85.71% 2 Missing ⚠️
src/notification-preferences/EmailCadences.jsx 90.00% 1 Missing ⚠️
src/notification-preferences/data/thunks.js 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1013      +/-   ##
==========================================
+ Coverage   56.53%   56.79%   +0.26%     
==========================================
  Files         118      119       +1     
  Lines        2457     2495      +38     
  Branches      654      673      +19     
==========================================
+ Hits         1389     1417      +28     
- Misses        997     1004       +7     
- Partials       71       74       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

src/index.scss Outdated Show resolved Hide resolved
src/index.scss Outdated Show resolved Hide resolved
src/notification-preferences/NotificationPreferenceApp.jsx Outdated Show resolved Hide resolved
src/notification-preferences/NotificationPreferenceApp.jsx Outdated Show resolved Hide resolved
src/notification-preferences/NotificationPreferenceApp.jsx Outdated Show resolved Hide resolved
src/notification-preferences/NotificationPreferenceRow.jsx Outdated Show resolved Hide resolved
src/notification-preferences/NotificationPreferenceRow.jsx Outdated Show resolved Hide resolved
src/notification-preferences/NotificationPreferenceRow.jsx Outdated Show resolved Hide resolved
src/notification-preferences/NotificationPreferenceRow.jsx Outdated Show resolved Hide resolved
src/notification-preferences/NotificationPreferenceRow.jsx Outdated Show resolved Hide resolved
src/index.scss Show resolved Hide resolved
@ayesha-waris ayesha-waris merged commit a266e3d into master Mar 25, 2024
9 checks passed
@ayesha-waris ayesha-waris deleted the Ayesha/1227 branch March 25, 2024 15:52
ayesha-waris added a commit that referenced this pull request Apr 5, 2024
ayesha-waris added a commit that referenced this pull request Apr 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants