-
Notifications
You must be signed in to change notification settings - Fork 122
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: implented notification preference UI for cadence #1013
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ayesha-waris
force-pushed
the
Ayesha/1227
branch
from
March 14, 2024 09:00
202a4d4
to
98fc826
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1013 +/- ##
==========================================
+ Coverage 56.53% 56.79% +0.26%
==========================================
Files 118 119 +1
Lines 2457 2495 +38
Branches 654 673 +19
==========================================
+ Hits 1389 1417 +28
- Misses 997 1004 +7
- Partials 71 74 +3 ☔ View full report in Codecov by Sentry. |
ayesha-waris
force-pushed
the
Ayesha/1227
branch
from
March 18, 2024 11:45
cb111e6
to
60aba32
Compare
awais-ansari
requested changes
Mar 18, 2024
awais-ansari
approved these changes
Mar 25, 2024
ayesha-waris
added a commit
that referenced
this pull request
Apr 5, 2024
This reverts commit a266e3d.
ayesha-waris
added a commit
that referenced
this pull request
Apr 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
INF-1227
Description:
We now will have a new email setting related to email cadences.
Options for email cadence for a notification can be Daily, Weekly and Immediately.
Complete UI as shown in mockup
Complete integration with BE to successfully update these email cadence settings