Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: removal of feature flags and release of exec ed inclusion #279

Merged

Conversation

alex-sheehan-edx
Copy link
Contributor

@alex-sheehan-edx alex-sheehan-edx commented Jan 10, 2023

https://2u-internal.atlassian.net/browse/ENT-6669

For all changes

  • Ensure adequate tests are in place (or reviewed existing tests cover changes)

Only if submitting a visual change

  • Ensure to attach screenshots
  • Ensure to have UX team confirm screenshots

@alex-sheehan-edx alex-sheehan-edx requested a review from a team January 10, 2023 19:53
@alex-sheehan-edx alex-sheehan-edx force-pushed the asheehan-edx/ENT-6669-exec-ed-inclusion-release branch from 1ee98f1 to ddff73f Compare January 10, 2023 21:11
@codecov
Copy link

codecov bot commented Jan 10, 2023

Codecov Report

Base: 82.44% // Head: 82.71% // Increases project coverage by +0.26% 🎉

Coverage data is based on head (ddff73f) compared to base (bbf795c).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #279      +/-   ##
==========================================
+ Coverage   82.44%   82.71%   +0.26%     
==========================================
  Files          39       39              
  Lines         729      723       -6     
  Branches      230      224       -6     
==========================================
- Hits          601      598       -3     
+ Misses        123      121       -2     
+ Partials        5        4       -1     
Impacted Files Coverage Δ
src/components/catalogPage/CatalogPage.jsx 97.56% <100.00%> (+6.86%) ⬆️
src/components/catalogs/CatalogSearch.jsx 80.82% <100.00%> (-1.00%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@alex-sheehan-edx alex-sheehan-edx merged commit ae56a33 into main Jan 11, 2023
@alex-sheehan-edx alex-sheehan-edx deleted the asheehan-edx/ENT-6669-exec-ed-inclusion-release branch January 11, 2023 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants