feat: removing public catalog's dependency on enterprise catalog default results #320
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alex-sheehan-edx
force-pushed
the
asheehan-edx/removing-catalog-dependencies
branch
10 times, most recently
from
96a62f3
to
ac98ec9
Compare
| @@ -90,18 +80,6 @@ describe('catalog no results deck works as expected', () => { | |||
| ); | |||
| }); | |||
| }); | |||
| test('API error responses will hide content deck', async () => { | |||
There was a problem hiding this comment.
not relevant any more because there are no api errors to deal with!
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #320 +/- ##
==========================================
- Coverage 83.24% 82.49% -0.75%
==========================================
Files 38 38
Lines 716 697 -19
Branches 221 219 -2
==========================================
- Hits 596 575 -21
- Misses 116 118 +2
Partials 4 4
☔ View full report in Codecov by Sentry. |
kiram15
reviewed
Jun 21, 2023
| @@ -523,23 +530,8 @@ describe('Main Catalogs view works as expected', () => { | |||
| ), | |||
| ).toBeInTheDocument(); | |||
| }); | |||
| test('no program search results displays popular programs text', async () => { | |||
There was a problem hiding this comment.
Why is this being taken out?
There was a problem hiding this comment.
we're not testing the no results component directly, we're testing the mocked algolia component is rendered in when there are no hits. As such, we don't need two tests saying "does it say programs" and "does it say courses" any more, just "does it say".
alex-sheehan-edx
force-pushed
the
asheehan-edx/removing-catalog-dependencies
branch
from
ac98ec9
to
718faf9
Compare
kiram15
approved these changes
Jun 21, 2023
alex-sheehan-edx
force-pushed
the
asheehan-edx/removing-catalog-dependencies
branch
3 times, most recently
from
666c578
to
088627e
Compare
alex-sheehan-edx
force-pushed
the
asheehan-edx/removing-catalog-dependencies
branch
from
088627e
to
92abf79
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Functionally, nothing changes with this PR as far as UX is concerned
What this PR does:
CatalogNoResultsDeckcomponent's call to the enterprise catalog service to fetch default algolia results.