-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: remove cta and hide notifications banner if no accounts url #347
base: master
Are you sure you want to change the base?
feat: remove cta and hide notifications banner if no accounts url #347
Conversation
Thanks for the pull request, @asadali145! What's next?Please work through the following steps to get your changes ready for engineering review: 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. 🔘 Let us know that your PR is ready for review:Who will review my changes?This repository is currently maintained by Where can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:
When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
730cebf
to
32e356a
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #347 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 111 109 -2
Lines 1082 1079 -3
Branches 160 161 +1
=========================================
- Hits 1082 1079 -3 ☔ View full report in Codecov by Sentry. |
bf6cc32
to
4c884d6
Compare
@jansenk Would you be able to review this PR? |
4c884d6
to
056f661
Compare
@brian-smith-tcril Would you be able to review this PR? |
Description:
CTA was added 2 years back. It is enabled by default and notification is visible all the time. This PR removes the CTA. If we still need CTA, we can put it behind a flag.
This PR also conditionally displays the notifications banner. Previously, If ACCOUNT_SETTINGS_URL was not set, it redirected to a 404
<lms_base_url>/notifications
.Screen Shots:
Before:
After: