feat: Updated frontend-build to bump jest version to v29 #317
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t-footer into bilalqamar95/frontend-build-jest-upgrade
BilalQamar95
force-pushed
the
bilalqamar95/frontend-build-jest-upgrade
branch
from
9d91817
to
f99472b
Compare
…t-footer into bilalqamar95/frontend-build-jest-upgrade
BilalQamar95
changed the title
…t-footer into bilalqamar95/frontend-build-jest-upgrade
package.json
Outdated
| }, | ||
| "peerDependencies": { | ||
| "@edx/frontend-platform": "^7.0.0", | ||
| "@edx/frontend-platform": "^8.0.0", |
There was a problem hiding this comment.
Suggested change
| "@edx/frontend-platform": "^8.0.0", | |
| "@edx/frontend-platform": "^7.0.0 || ^8.0.0", |
i think we should add support of frontend-platform v7 here as well because a consumer will not break if it uses v7 or v8 of frontend-platform since frontend-platform v8 doesn't have any breaking changes except frontend-build peer dependency change. Moreover, we are opening PRs in respective MFEs as well with frontend-build and frontend-platform upgrade, i think we can handle this manually in those PRs. In this way we don't have to release it as a breaking change.
abdullahwaheed
approved these changes
Apr 23, 2024
BilalQamar95
changed the title
Merged
6 tasks
ArturGaspar
added a commit
to open-craft/frontend-component-footer
that referenced
this pull request
Sep 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
jestto v29 &frontend-buildmajor version upgradefrontend-platformto v8