Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DEPR]: Remove Learner View in Insights, Data API, and Pipeline #36

Closed
ashultz0 opened this issue Mar 7, 2022 · 13 comments
Closed

[DEPR]: Remove Learner View in Insights, Data API, and Pipeline #36

ashultz0 opened this issue Mar 7, 2022 · 13 comments
Labels
depr Proposal for deprecation & removal per OEP-21

Comments

@ashultz0
Copy link

ashultz0 commented Mar 7, 2022

Editorial note: This deprecated a particular view in Insights ("Learner View"), plus that view's supporting code in other analytics repos. It didn't entirely deprecate Insights and all associated analytics repos. -Kyle


Proposal Date

3 March 2022

Ticket Acceptance Date

31 March 2022

Technology Removal Date

May 1 2022

First Open edX Named Release Without This Functionality

Olive

Rationale

The learner view in insights and associated data API and pipeline are expensive to operate and provide data out of alignment with the rest of analytics. It is so detailed that it provides too much individual data to be viewable for a course with more than a few students, and that data creates PII risk.

Most of analytics is aggregated data. The learner view contains individual information including usernames and emails. This means that the learner view includes sensitive PII. This creates unnecessary security concerns Insights as well as the entire pipeline and API.

To support this data requires an expensive pipeline job and an elasticsearch cluster ( see #16 ). On edx.org, data supporting this view is roughly as as the rest of Insights combined.

Removal

Insights code supporting the learner view such as: https://github.com/openedx/edx-analytics-dashboard/tree/master/analytics_dashboard/learner_analytics_api

Learner view data API code such as https://github.com/openedx/edx-analytics-data-api/blob/master/analytics_data_api/v0/views/learners.py as well as elasticsearch support code and the corresponding calls in https://github.com/openedx/edx-analytics-data-api-client

Learner view pipeline support such as https://github.com/edx/edx-analytics-pipeline/blob/master/edx/analytics/tasks/insights/module_engagement.py and elasticsearch support.

Replacement

There is no replacement currently planned.

Deprecation

No response

Migration

No response

Additional Info

No response

@ashultz0 ashultz0 added the depr Proposal for deprecation & removal per OEP-21 label Mar 7, 2022
@dianakhuang
Copy link

This is still under discussion after the accepted date. See the Discourse post for more details.

@jmbowman
Copy link

The Discourse post resolved at it being ok for us to remove this, just need to actually rip it out now.

@pdpinch
Copy link

pdpinch commented Dec 18, 2022

When I was looking through the commit history to prepare the olive release notes, I found the following PRs, which suggest that this feature has been removed.

Can this issue be closed, or at least updated?

@ashultz0
Copy link
Author

It has been removed from the frontend parts of the system but there are some reports in enterprise code tied to the back end structures that have to be rooted out as well to close this and then the back end itself can be removed.

As far as Olive is concerned this feature is not available, but the code is still being mined out.

@bmtcril
Copy link

bmtcril commented Apr 11, 2023

Is this still being worked on, or can this ticket be closed out?

@ashultz0
Copy link
Author

still in the yak shaving stage of trying to get rid of the code that lets us get rid of the code that lets us get rid of the code :(

@jmbowman
Copy link

Can we ticket up and link that chain of code removal, or at least the task that's currently blocking this?

@ashultz0
Copy link
Author

I'm a bit detached from where this is now because I've changed groups so I summon @alangsto who is another person who knows something :)

@alangsto
Copy link

Cosmonauts has tickets to remove the learner view, but the work has not been prioritized. If this work should be prioritized, I can bring it up during our next grooming meeting.

@kdmccormick
Copy link
Member

Could you link the tickets here Ali? I understand that they're probably 2U-internal, but I'd like to tie all threads together here, whether private or public.

@alangsto
Copy link

Here is the link to the epic: https://2u-internal.atlassian.net/browse/MST-1428

@dianakhuang
Copy link

This is being closed in favor #221 , since that other ticket will cover these views.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
depr Proposal for deprecation & removal per OEP-21
Projects
Archived in project
Development

No branches or pull requests

7 participants