This repository has been archived by the owner on Aug 21, 2024. It is now read-only.
chore: deprecate learner view #1332
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alangsto
force-pushed
the
alangsto/remove_learner_view
branch
6 times, most recently
from
a30fc86
to
2a34a55
Compare
ashultz0
reviewed
Jul 14, 2022
| # Some orgs do not wish to allow access to learner analytics. | ||
| # See https://openedx.atlassian.net/browse/DENG-536 | ||
| course_org = CourseKey.from_string(self.course_id).org | ||
| if course_org in settings.BLOCK_LEARNER_ANALYTICS_ORG_LIST: |
There was a problem hiding this comment.
we should scrub out this setting later, it exists in edx-internal
There was a problem hiding this comment.
sounds good, I will leave in code that relates to this setting then
There was a problem hiding this comment.
Created https://github.com/edx/edx-internal/pull/6880 for removing this settings from edx-internal
ashultz0
approved these changes
Jul 14, 2022
alangsto
force-pushed
the
alangsto/remove_learner_view
branch
from
2a34a55
to
b83bcd5
Compare
This was referenced Dec 18, 2022
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove all code associated with the learner view.