Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feanil/fix cla check #403

Merged
merged 2 commits into from
Jun 21, 2023
Merged

feanil/fix cla check #403

merged 2 commits into from
Jun 21, 2023

Conversation

feanil
Copy link
Contributor

@feanil feanil commented Jun 21, 2023

  • fix: Provide branch protection params as scalers not lists.
  • style: Run black.

@feanil
fix: Provide branch protection params as scalers not lists.
2489481 
The parens were resulting in the values for the `requierd_pr_reviews`
parameter to be set to lists of bools and ints instead of just bools and
int directly.
@feanil
style: Run black.
03186dc
@feanil feanil requested a review from kdmccormick June 21, 2023 15:57
kdmccormick
kdmccormick approved these changes Jun 21, 2023
View reviewed changes
Copy link
Member

@kdmccormick kdmccormick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whoops, I might've done that when I moved this to repo-tools, my bad.

@feanil feanil merged commit 54ca13c into master Jun 21, 2023
2 checks passed
@feanil feanil deleted the feanil/fix_cla_check branch June 21, 2023 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kdmccormick kdmccormick kdmccormick approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@feanil @kdmccormick