Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test(fix): we were accidentally making temp directories in the project instead of in /tmp #420

Merged
merged 1 commit into from
Jul 26, 2023
Merged

test(fix): we were accidentally making temp directories in the project instead of in /tmp #420

merged 1 commit into from
Jul 26, 2023

Conversation

nedbat
Copy link
Contributor

@nedbat nedbat commented Jul 26, 2023

This creates those fake_repo directories in tmpdir instead. Now we don't need to gitignore them.

@nedbat nedbat requested a review from aht007 July 26, 2023 15:00
aht007
aht007 approved these changes Jul 26, 2023
View reviewed changes
Copy link
Member

@aht007 aht007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, Interesting... I remember this was an issue back then and I had to add the directory to gitignore. Nice catch though. Thanks

@nedbat nedbat merged commit ca56c81 into master Jul 26, 2023
2 checks passed
@nedbat nedbat deleted the nedbat/misc-fixes branch July 26, 2023 18:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aht007 aht007 aht007 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nedbat @aht007