Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python script to find the python dependencies sources #509

Merged

Conversation

salman2013
Copy link
Contributor

No description provided.

@salman2013 salman2013 changed the title chore: add script to find python dependencies Python script to find the python dependencies sources May 6, 2024
@salman2013 salman2013 marked this pull request as ready for review May 6, 2024 11:12
Copy link
Contributor

@feanil feanil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should also add this to the set of runnable scripts: https://github.com/openedx/repo-tools/blob/master/setup.py#L91-L122

This will let you run this script after you install it via pip.

@salman2013 salman2013 requested a review from feanil May 8, 2024 12:01
@salman2013 salman2013 closed this May 13, 2024
@salman2013 salman2013 reopened this May 13, 2024
Copy link
Contributor

@feanil feanil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should also add requirements-parser to https://github.com/openedx/repo-tools/blob/master/edx_repo_tools/find_dependencies/extra.in so that we don't have to manually install it in workflows.

@salman2013 salman2013 requested a review from feanil May 27, 2024 12:09
@salman2013 salman2013 requested a review from feanil May 28, 2024 18:10
Copy link
Contributor

@feanil feanil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did the following testing an saw errors:

pip install -e '.[find_dependencies]'
find_python_dependencies # Expected to see the click help output.
find_python_dependencies --help # Also throws errors.

It also looks like the ignore_paths setting is not being used to actually ignore anything?

Copy link
Contributor

@feanil feanil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The output is not quite right yet:

❯ find_python_dependencies --req-file ~/src/openedx/edx-platform/requirements/edx/base.txt  --ignore https://github.com/mitodl/edx-sga

Second party packages:
https://github.com/edx/codejail-includes
https://github.com/edx/braze-client
https://github.com/edx/edx-name-affirmation
https://github.com/mitodl/edx-sga
https://github.com/edx/token-utils
https://github.com/open-craft/xblock-poll

If I'm only ignoring one of the packages, that one should not be listed, only the packages that are not being ignored should be listed.

@salman2013 salman2013 force-pushed the salman/add-script-for-python-dependencies branch from c54e7ec to e0a5aeb Compare June 5, 2024 11:38
@salman2013 salman2013 requested a review from feanil June 5, 2024 11:52
Copy link
Contributor

@feanil feanil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple of final suggestions, great job with all the back and forth.

@salman2013 salman2013 closed this Jun 6, 2024
@salman2013 salman2013 reopened this Jun 6, 2024
@salman2013 salman2013 force-pushed the salman/add-script-for-python-dependencies branch from fda069d to 7446bdc Compare June 6, 2024 10:56
@feanil feanil force-pushed the salman/add-script-for-python-dependencies branch 4 times, most recently from 7f14755 to 65307d0 Compare June 7, 2024 15:18
@feanil feanil force-pushed the salman/add-script-for-python-dependencies branch from 65307d0 to 75172eb Compare June 7, 2024 15:26
We are adding a new dependency script so bump the version in preparation
for a release.
@feanil feanil merged commit 31f6be7 into openedx:master Jun 7, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants