This repository has been archived by the owner on Nov 6, 2020. It is now read-only.
[devp2p discovery]: remove deprecated_echo_hash
#11564
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removes support for `deprecated_echo_hash` ping/pong in devp2p-discovery. It will not work with nodes prior to `stable 2.0.5` (#9526)
niklasad1
commented
Mar 11, 2020
|
|
||
| if node_entry.endpoint.is_valid_sync_node() { | ||
| let mut added = HashMap::with_capacity(1); |
There was a problem hiding this comment.
move this here, to not have to clone it.
niklasad1
commented
Mar 11, 2020
| None | ||
| }, | ||
| Entry::Occupied(entry) => { | ||
| let request = entry.remove(); |
There was a problem hiding this comment.
entry::remove() returns it by value, thus clone removed.
ordian
added
A8-looksgood 🦄
dvdplm
approved these changes
Mar 17, 2020
ordian
added a commit
that referenced
this pull request
Mar 24, 2020
* master: informant: display I/O stats (#11523) [devp2p discovery]: remove `deprecated_echo_hash` (#11564) [secretstore] create db_version file when database doesn't exist (#11570) Remove Parity's Security Policy (#11565) ethcore/res: enable ecip-1088 phoenix upgrade for kotti and mordor testnets (#11529) Misc docs and renames …and one less clone (#11556) [secretstore]: don't sign message with only zeroes (#11561) [devp2p discovery]: cleanup (#11547) Code cleanup in the sync module (#11552) initial cleanup (#11542) Warn if genesis constructor revert (#11550)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes support for
deprecated_echo_hashping/pong messages in devp2p-discovery.It will not work with nodes prior to
stable 2.0.5(#9526) anymore