This repository has been archived by the owner on Nov 6, 2020. It is now read-only.
EIP-212 (bn128 curve pairing) #5307
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NikVolf
added
A3-inprogress ⏳
|
for reference ethereum/EIPs#212 |
NikVolf
added
A0-pleasereview 🤓
|
@arkpar |
rphmeier
reviewed
Apr 5, 2017
ethcore/src/builtin.rs
Outdated
| @@ -191,6 +192,9 @@ struct Bn128AddImpl; | |||
| #[derive(Debug)] | |||
| struct Bn128MulImpl; | |||
|
|
|||
| #[derive(Debug)] | |||
| struct Bn128ParingImpl; | |||
rphmeier
reviewed
Apr 5, 2017
| fn execute(&self, input: &[u8], output: &mut BytesRef) -> Result<(), Error> { | ||
| use bn::{AffineG1, AffineG2, Fq, Fq2, pairing, G1, G2, Gt}; | ||
|
|
||
| let elements = input.len() / 192; // (a, b_a, b_b - each 64-byte affine coordinates) |
There was a problem hiding this comment.
Isn't the input for builtins supposed to be infinitely zero-extended?
There was a problem hiding this comment.
For this builtin, no.
|
Could you give a summary of changes to the "bn" library? |
|
no new logic, just some internal api exposed, which will allow
|
arkpar
added
A8-looksgood 🦄
rphmeier
reviewed
Apr 19, 2017
ethcore/src/builtin.rs
Outdated
| @@ -713,7 +815,82 @@ mod tests { | |||
| assert!(res.is_err(), "There should be built-in error here"); | |||
| } | |||
| } | |||
|
|
|||
| fn builitin_pairing() -> Builtin { | |||
rphmeier
added
A5-grumble 🔥
NikVolf
added
A0-pleasereview 🤓
rphmeier
added
A8-looksgood 🦄
rphmeier
reviewed
Apr 21, 2017
| ).expect("Generator P1(1, 2) is a valid curve point")); | ||
| } | ||
|
|
||
| lazy_static! { |
There was a problem hiding this comment.
I believe these 3 lazy_static invocations could be combined. These are generators for alt_bn128, right? Eventually it would be nice to have these extracted to constants in a bn::alt_gen module, but not a blocker for now.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
goes after #4999