apiVersions #17
Merged
apiVersions #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rename apiVersion from certmanager.k8s.io/v1alpha1 to cert-manager.io/v1alpha2 Signed-off-by: Christian Sakshaug <christian@dx.no>
|
Perhaps check https://docs.openfaas.com/reference/ssl/kubernetes-with-cert-manager/#install-cert-manager and the README.md after that. |
alexellis
reviewed
Nov 5, 2019
alexellis
added a commit
that referenced
this pull request
Feb 5, 2020
As a result of merging #17, the README was incorrect. This patch corrects the issues. Ref: https://cert-manager.io/docs/tutorials/acme/http-validation Signed-off-by: Alex Ellis (OpenFaaS Ltd) <alexellis2@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rename apiVersion from certmanager.k8s.io/v1alpha1 to cert-manager.io/v1alpha2
Signed-off-by: Christian Sakshaug christian@dx.no