Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move to Go modules and use Go client 1.17 #22

Merged
merged 10 commits into from
Feb 4, 2020

Conversation

alexellis
Copy link
Member

@alexellis alexellis commented Feb 4, 2020

Move to Go modules and use Go client 1.17

This change is being made to bring the operator into parity with
faas-netes and the openfaas-operator.

  • Uses k8s Go client version 1.17
  • Uses Go modules for dependencies

Vendor folder updated and update-codegen ran, fixed any
compilation errors from Ingress moving out of extensions and
into networking/v1beta1.

I believe that this changes breaks compatibility with Kubernetes 1.13 and lower
with 1.14 being the new min version.

Testing:

k3sup app install openfaas --set ingressOperator.create=true --set ingressOperator.image=openfaas/ingress-operator:0.5.1-rc2-amd64

faas-cli store deploy nodeinfo
kubectl port-forward -n kube-system svc/traefik 8081:80 &

kubectl apply -f ./artifacts/nodeinfo-ingress-traefik.yaml

kubectl get ingress -n openfaas -w

curl http://127.0.0.1:8081 -H "Host: nodeinfo.myfaas.club"

https://github.com/openfaas-incubator/ingress-operator/pull/22

I also had to bump up the Chart to give access to the networking.k8s.io apiGroup.

Signed-off-by: Alex Ellis (OpenFaaS Ltd) alexellis2@gmail.com

* Uses k8s Go client version 1.17
* Uses Go modules for dependencies

Vendor folder updated and update-codegen ran, fixed any
compilation errors from Ingress moving out of extensions and
into networking/v1beta1.

Signed-off-by: Alex Ellis (OpenFaaS Ltd) <alexellis2@gmail.com>
Signed-off-by: Alex Ellis (OpenFaaS Ltd) <alexellis2@gmail.com>
Signed-off-by: Alex Ellis (OpenFaaS Ltd) <alexellis2@gmail.com>
Signed-off-by: Alex Ellis (OpenFaaS Ltd) <alexellis2@gmail.com>
Trying to fix the CI

Signed-off-by: Alex Ellis (OpenFaaS Ltd) <alexellis2@gmail.com>
The build is running tests and downloading files even though
they are present in vendor.

Signed-off-by: Alex Ellis (OpenFaaS Ltd) <alexellis2@gmail.com>
The array format was causing a matrix build.

Signed-off-by: Alex Ellis (OpenFaaS Ltd) <alexellis2@gmail.com>
Signed-off-by: Alex Ellis (OpenFaaS Ltd) <alexellis2@gmail.com>
klog is now being used by the Go client, so renaming references
to match.

Signed-off-by: Alex Ellis (OpenFaaS Ltd) <alexellis2@gmail.com>
The files are present in the vendor folder, no need to slow
down the build more.

Signed-off-by: Alex Ellis (OpenFaaS Ltd) <alexellis2@gmail.com>
@alexellis alexellis merged commit deaa32a into master Feb 4, 2020
@alexellis alexellis deleted the openfaasltd/go-client-1-17-and-modules branch February 4, 2020 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant