Added Label To DockerFile #56
Conversation
Dockerfile
Outdated
| @@ -41,6 +41,10 @@ RUN go build -mod=vendor -ldflags "-s -w \ | |||
|
|
|||
| FROM scratch | |||
|
|
|||
| ARG REPO_URL | |||
There was a problem hiding this comment.
What made you make this REPO_URL?
Where is REPO_URL getting populated from?
There was a problem hiding this comment.
I guess the other way of asking this question is: have you tested this change? (My hunch is that you haven't, but that is part of the PR template that we ask you to fill out)
There was a problem hiding this comment.
I did a local docker build, I'll run as the setup suggests, should all the Labels: this values org.opencontainers.image.source=https://github.com/openfaas/faas ?
- Applying fix
- Running local tests
There was a problem hiding this comment.
I have applied the change as expected. Does it full fill the requirement?
There was a problem hiding this comment.
It looks good.
REPO_URL could be useful, but we need to make sure it's determined and then injected in via the GitHub Action that publishes the image.
Please update the section "How Has This Been Tested?" with the specific steps you took, even the command lines.
There was a problem hiding this comment.
I have added a docker build test and inspection output. Is there a specific way could test this change? any pointers would really help. @alexellis
|
Thank you for your contribution. unfortunately, one or more of your commits are missing the required "Signed-off-by:" statement. Signing off is part of the Developer Certificate of Origin (DCO) which is used by this project. Read the DCO and project contributing guide carefully, and amend your commits using the git CLI. Note that this does not require any cryptography, keys or special steps to be taken. 💡 Shall we fix this?This will only take a few moments. First, clone your fork and checkout this branch using the git CLI. Next, set up your real name and email address:
Finally, run one of these commands to add the "Signed-off-by" line to your commits. If you only have one commit so far then run: Check that the message has been added properly by running "git log". |
j0nimost
force-pushed
the
fix-adding-label
branch
from
630f530
to
d211dc0
Compare
|
We ended up with two commits (the first attempt, then the second attempt), but only want one for the history in git. Feel up to trying to squash them down into one? |
j0nimost
force-pushed
the
fix-adding-label
branch
from
d211dc0
to
3d5897c
Compare
|
Rebase Completed |
Dockerfile
Outdated
| @@ -41,6 +41,8 @@ RUN go build -mod=vendor -ldflags "-s -w \ | |||
|
|
|||
| FROM scratch | |||
|
|
|||
| LABEL org.opencontainers.image.source=https://github.com/openfaas/faas | |||
There was a problem hiding this comment.
This is the wrong label. It should match the repository building the code, i.e. this one.
There was a problem hiding this comment.
| LABEL org.opencontainers.image.source=https://github.com/openfaas/faas | |
| LABEL org.opencontainers.image.source=https://github.com/openfaas/ingress-operator |
I have updated the URL
Signed-off-by: John Nyingi <john.nyingi@live.com>
j0nimost
force-pushed
the
fix-adding-label
branch
from
3d5897c
to
1456d3a
Compare
|
Kindly review |
|
That is perfect, thank you :) Just for future reference rather than "Added label" in the commit message, perhaps we could be more instructive for future folks who are reading history? "Added open containers label to Dockerfile" for instance. |
Description
To allow for easy update of the Build Status I have added a
LABELtag which will inferopenfaas/faasMotivation and Context
How Has This Been Tested?
I did a docker build to test the image build
docker build -t ingress-op .Inspect out is as shown below
Types of changes
Impact to existing users
Checklist:
git commit -s