Skip to content

Commit

Permalink
fix: avoid making taxonomy query with empty parameters
Browse files Browse the repository at this point in the history
Avoid raising an error
  • Loading branch information
alexgarel committed Oct 21, 2022
1 parent 4a3e5f0 commit 0b9dfd6
Showing 1 changed file with 9 additions and 12 deletions.
21 changes: 9 additions & 12 deletions app/knowledge_panels.py
Original file line number Diff line number Diff line change
Expand Up @@ -190,24 +190,21 @@ async def _wikidata_kp(self, facet, value):
query["tagtype"] = facet_plural(facet=facet)
query["fields"] = "wikidata"
query["tags"] = value

entities = await wikidata_helper(query=query, value=value)

return entities
return await wikidata_helper(query=query, value=value)

async def wikidata_kp(self):
"""
Return knowledge panel for wikidata
"""
entities = set()
try:
entities.add(await self._wikidata_kp(facet=self.facet, value=self.value))
except Exception:
logging.exception("While adding wikidata for primary facet")
try:
entities.add(await self._wikidata_kp(facet=self.sec_facet, value=self.sec_value))
except Exception:
logging.exception("While adding wikidata for secandary facet")
params = ((self.facet, self.value), (self.sec_facet, self.sec_value))
for facet, value in params:
try:
entity = await self._wikidata_kp(facet=facet, value=value)
if entity is not None:
entities.add(entity)
except Exception:
logging.exception("While adding wikidata for primary facet")

html = []
info = []
Expand Down

0 comments on commit 0b9dfd6

Please sign in to comment.