Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The "No Nutrition facts" toggle does not work correctly #4582

Closed
teolemon opened this issue Mar 22, 2022 · 10 comments · Fixed by #4583 or #4596
Closed

The "No Nutrition facts" toggle does not work correctly #4582

teolemon opened this issue Mar 22, 2022 · 10 comments · Fixed by #4583 or #4596
Assignees
@g123k
Labels
bug Produces incorrect or unexpected result or behaviour. nutrition editing P1

Comments

@teolemon
Copy link
Member

What

  • The "No Nutrition facts" toggle does not work correctly

Part of

Video

screen-20220322-093150.mp4
@teolemon teolemon added bug Produces incorrect or unexpected result or behaviour. nutrition editing labels Mar 22, 2022
@teolemon teolemon mentioned this issue Mar 22, 2022
Merged
@g123k g123k mentioned this issue Mar 22, 2022
Merged
@g123k g123k linked a pull request Mar 22, 2022 that will close this issue
fix: "No nutrition facts" switch not working as intended #4583
Merged
@g123k g123k self-assigned this Mar 22, 2022
@teolemon
Copy link
Member Author

teolemon commented Mar 23, 2022 •
edited
Loading

Still not working: https://world.openfoodfacts.org/product/3021891403241/chargement

@teolemon teolemon reopened this Mar 23, 2022
@teolemon
Copy link
Member Author

image

@g123k
Copy link
Contributor

g123k commented Mar 23, 2022

What's wrong exactly?

Because I can see the banner on your product:
Screen Shot 2022-03-23 at 12 10 50

@teolemon
Copy link
Member Author

I'm trying to reenable them, and I can't

@g123k
Copy link
Contributor

g123k commented Mar 23, 2022

Ok, I understood, I have to force the value

@teolemon teolemon added the P1 label Mar 23, 2022
@g123k g123k linked a pull request Mar 23, 2022 that will close this issue
fix: No nutrition data: Ensure empty values are sent to the server #4596
Merged
@teolemon teolemon reopened this Mar 23, 2022
@teolemon
Copy link
Member Author

teolemon commented Mar 23, 2022 •
edited
Loading

The edit is not honored when I try editing the alcohol level.
In fact, it does not honor other fields.

@g123k
Copy link
Contributor

g123k commented Mar 23, 2022

Are you sure @teolemon?

On your product (https://world.openfoodfacts.org/product/3021891403241/loading), my edits were perfectly saved, including the alcohol level

Screen Shot 2022-03-23 at 14 37 44

@teolemon
Copy link
Member Author

it seems to be working now

@g123k
Copy link
Contributor

g123k commented Mar 25, 2022

@teolemon Can we close this issue?

@teolemon
Copy link
Member Author

Closed, thank you 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@g123k g123k

Labels
bug Produces incorrect or unexpected result or behaviour. nutrition editing P1
Projects
None yet
Milestone
No milestone
2 participants
@g123k @teolemon