fix: "No nutrition facts" switch not working as intended #4583
Conversation
g123k
changed the title
| @@ -551,10 +555,11 @@ class ProductEditNutritionFactsFragment : ProductEditFragment() { | |||
| // Add no nutrition data entry to map | |||
| if (binding.checkboxNoNutritionData.isChecked) { | |||
| targetMap[ApiFields.Keys.NO_NUTRITION_DATA] = "on" | |||
There was a problem hiding this comment.
So we send the boolean to deactivate, but do we send the boolean to reactivate, along or before nutrients ?
There was a problem hiding this comment.
You're right, this is not the case right now.
Currently in the code, the app checks if the field is null (= no nutrition data) or == "ON"
So I will just send a null in the other cases. Otherwise I am afraid of generating some bugs
There was a problem hiding this comment.
That should be OK right now, with the new commit #9ce02dd
… the rest of the UI shouldn't be displayed + no other field sent to the API
g123k
force-pushed
the
nutrional_facts_edition_no_nutrition
branch
from
b36c782
to
9ce02dd
Compare
| @@ -575,6 +575,10 @@ class ProductEditNutritionFactsFragment : ProductEditFragment() { | |||
| targetMap += getNutrientMapIfUpdated(view) | |||
| } | |||
|
|
|||
| // We force a null value here for "no nutrition", instead of an "off" String, | |||
| // to be sure to do not break other apps | |||
| targetMap[ApiFields.Keys.NO_NUTRITION_DATA] = null | |||
There was a problem hiding this comment.
There was a problem hiding this comment.
Look at line 335, on Android the check is if != null -> true
I have improved the checks to ensure, "on" is true and everything else is false
|
The code should now be OK with comments from openfoodfacts/api-documentation#70 |
|
Kudos, SonarCloud Quality Gate passed!
|
|
thank you @g123k , merging and releasing to internal 👍 |
PR that fixes two issues:
#4582