Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

adds prompt for missing info related to Eco-Score (solves issue 3624) #3644

Merged
merged 6 commits into from
Jan 16, 2021
Merged

adds prompt for missing info related to Eco-Score (solves issue 3624) #3644

merged 6 commits into from
Jan 16, 2021

Conversation

kartikaysharma01
Copy link
Contributor

@kartikaysharma01 kartikaysharma01 commented Dec 29, 2020 •
edited
Loading

Description

adds prompt for missing info related to Eco-Score.

I have additionally added the following condition, feel free to remove it if required.

if (nutrition-facts-to-be-completed && categories-completed in states) && ecoscore == null
"Eco-Score could not be computed for this product. Add nutrition facts to compute the Nutri-Score"

Related issues

Fixes #3624
Fixes #3710

Related PRs

Screenshots

@teolemon
Copy link
Member

@stephanegigandet we'd need an origins-to-be-completed state (as described in: openfoodfacts/openfoodfacts-server#4661)

@teolemon
Copy link
Member

@kartikaysharma01 can you add a quick screenshot ?

@teolemon teolemon changed the title Issue 3624 resolved adds prompt for missing info related to Eco-Score (solves issue 3624) Dec 29, 2020
@teolemon teolemon mentioned this pull request Dec 29, 2020
Closed
@teolemon
Copy link
Member

image
How about a 1 time message ?

@teolemon
Copy link
Member

teolemon commented Dec 31, 2020 •
edited
Loading

and for the others, text rather than buttons, below the "Take additional photos" button ?
image
@VaiTon ?

@VaiTon
Copy link
Member

VaiTon commented Jan 3, 2021

I agree, @kartikaysharma01 do you want to proceed? Any comment?

@kartikaysharma01
Copy link
Contributor Author

@VaiTon We already talked about this here

@VaiTon
Copy link
Member

VaiTon commented Jan 3, 2021

@kartikaysharma01 needs rebase

@kartikaysharma01
Copy link
Contributor Author

Description
adds prompt for missing info related to Eco-Score.
I have added a additional layout for Tip Box, to get the desired design. On clicking the mail, the user is forwarded to mail applications on the device.

Related issues
Fixes #3624
Fixes #3710

Screenshots
show CategoryPrompt and OriginPrompt
WhatsApp Image 2021-01-12 at 23 14 23 (2)

show EcoScorePrompt and OriginPrompt

WhatsApp Image 2021-01-12 at 23 14 23 (1)

On clicking the mail text:-

WhatsApp Image 2021-01-12 at 23 14 23

@kartikaysharma01
Copy link
Contributor Author

@VaiTon Please review this.

@VaiTon
Copy link
Member

VaiTon commented Jan 13, 2021

@kartikaysharma01 push new changes and we can merge! 🎉

@sonarcloud
Copy link

sonarcloud bot commented Jan 13, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@kartikaysharma01
Copy link
Contributor Author

@VaiTon pushed the changes.

@kartikaysharma01
Copy link
Contributor Author

@VaiTon Is there any other change to be made??

@VaiTon VaiTon merged commit 025a663 into openfoodfacts:develop Jan 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@VaiTon VaiTon VaiTon left review comments

@stephanegigandet stephanegigandet Awaiting requested review from stephanegigandet

Assignees
No one assigned
Labels
road to scores
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Tip System is broken Add a message if we have a category but no Eco-Score
3 participants
@kartikaysharma01 @teolemon @VaiTon