Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue/4141 improve edit mode by fixing button at the bottom #4332

Conversation

Farbklex
Copy link
Contributor

@Farbklex Farbklex commented Oct 26, 2021

Description

Turn the "next" and "save" buttons in the edit screens to sticky buttons which are always visible at the bottom.
Additionally, fix wrong clipping in the scrollviews.

Related issues

Screenshots

Emulator, Nexus S, API 21:
Nexus S API 21

Emulator, Pixel C, API 30:
Pixel C API 30

Link to the automatically generated build APK

OFF APK: https://github.com/openfoodfacts/openfoodfacts-androidapp/suites/4170189320/artifacts/107241185

@sonarcloud
Copy link

sonarcloud bot commented Oct 26, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@teolemon teolemon requested a review from a team October 26, 2021 21:52
@teolemon teolemon added the editing Issues relating to allowing the user to edit products label Oct 27, 2021
@VaiTon
Copy link
Member

VaiTon commented Oct 27, 2021

LGTM ✅

@VaiTon VaiTon merged commit 3f02a3d into openfoodfacts:develop Oct 27, 2021
@Farbklex Farbklex deleted the issue/4141-Improve-edit-mode-by-fixing-button-at-the-bottom branch November 10, 2021 21:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
editing Issues relating to allowing the user to edit products
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve edit mode by fixing "Next" and "Save" button at the bottom of the screen
3 participants