Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: used OffTagged and removed deprecated fields #607

Merged
merged 1 commit into from
Nov 6, 2022

Conversation

monsieurtanuki
Copy link
Contributor

Impacted files:

  • AbstractQueryConfiguration.dart: removed deprecated field cc
  • OpenFoodAPIConfiguration.dart: removed deprecated field globalCc
  • ProductListQueryConfiguration.dart: removed deprecated field cc
  • ProductQueryConfigurations.dart: removed deprecated field cc
  • ProductSearchQueryConfiguration.dart: removed deprecated field cc
  • TagFilter.dart: refactored with OffTagged; removed deprecated constructor
  • TaxonomyAdditive.dart: removed deprecated field cc
  • TaxonomyAllergen.dart: removed deprecated field cc
  • TaxonomyCategory.dart: removed deprecated field cc
  • TaxonomyCountry.dart: removed deprecated field cc; refactored with OffTagged
  • TaxonomyIngredient.dart: removed deprecated field cc
  • TaxonomyLabel.dart: removed deprecated field cc
  • TaxonomyLanguage.dart: removed deprecated field cc
  • TaxonomyQueryConfiguration.dart: removed deprecated field cc

What

Impacted files:
* `AbstractQueryConfiguration.dart`: removed deprecated field `cc`
* `OpenFoodAPIConfiguration.dart`: removed deprecated field `globalCc`
* `ProductListQueryConfiguration.dart`: removed deprecated field `cc`
* `ProductQueryConfigurations.dart`: removed deprecated field `cc`
* `ProductSearchQueryConfiguration.dart`: removed deprecated field `cc`
* `TagFilter.dart`: refactored with `OffTagged`; removed deprecated constructor
* `TaxonomyAdditive.dart`: removed deprecated field `cc`
* `TaxonomyAllergen.dart`: removed deprecated field `cc`
* `TaxonomyCategory.dart`: removed deprecated field `cc`
* `TaxonomyCountry.dart`: removed deprecated field `cc`; refactored with `OffTagged`
* `TaxonomyIngredient.dart`: removed deprecated field `cc`
* `TaxonomyLabel.dart`: removed deprecated field `cc`
* `TaxonomyLanguage.dart`: removed deprecated field `cc`
* `TaxonomyQueryConfiguration.dart`: removed deprecated field `cc`
Copy link
Member

@M123-dev M123-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks @monsieurtanuki

@monsieurtanuki monsieurtanuki merged commit 39e17a6 into openfoodfacts:master Nov 6, 2022
@monsieurtanuki
Copy link
Contributor Author

Thank you @M123-dev for your review!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants