fix: #571 - last step of migration of enums to dart 2.17 #623
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Impacted files: * `AbstractQueryConfiguration.dart`: minor refactoring * `api_getProduct_test.dart`: minor refactoring * `CountryHelper.dart`: upgraded `OpenFoodFactsCountry` to dart 2.17 * `ImageHelper.dart`: minor refactoring * `JsonHelper.dart`: minor refactoring * `LanguageHelper.dart`: upgraded `OpenFoodFactsLanguage` to dart 2.17 * `NutrientsLevels.dart`: upgraded `Level` to dart 2.17 * `OpenFoodAPIConfiguration.dart`: minor refactoring * `openfoodfacts.dart`: minor refactoring * `ordered_nutrient_test.dart`: minor refactoring * `Product.dart`: minor refactoring * `ProductFields.dart`: minor refactoring * `ProductImage.dart`: upgraded `ImageField`, `ImageSize`, `ImageAngle` to dart 2.17; minor refactoring * `SendImage.dart`: minor refactoring * `State.dart`: upgraded `State` to dart 2.17 * `TaxonomyQueryConfiguration.dart`: minor refactoring * `UriHelper.dart`: minor refactoring
Codecov Report
@@ Coverage Diff @@
## master #623 +/- ##
==========================================
- Coverage 68.58% 68.39% -0.20%
==========================================
Files 185 184 -1
Lines 7598 7615 +17
==========================================
- Hits 5211 5208 -3
- Misses 2387 2407 +20
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
M123-dev
approved these changes
Nov 13, 2022
There was a problem hiding this comment.
I didn't double check all the fields but looks good. Thanks for this big refactoring @monsieurtanuki 🥇
|
Thank you @M123-dev for the review! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Impacted files:
AbstractQueryConfiguration.dart: minor refactoringapi_getProduct_test.dart: minor refactoringCountryHelper.dart: upgradedOpenFoodFactsCountryto dart 2.17ImageHelper.dart: minor refactoringJsonHelper.dart: minor refactoringLanguageHelper.dart: upgradedOpenFoodFactsLanguageto dart 2.17NutrientsLevels.dart: upgradedLevelto dart 2.17OpenFoodAPIConfiguration.dart: minor refactoringopenfoodfacts.dart: minor refactoringordered_nutrient_test.dart: minor refactoringProduct.dart: minor refactoringProductFields.dart: minor refactoringProductImage.dart: upgradedImageField,ImageSize,ImageAngleto dart 2.17; minor refactoringSendImage.dart: minor refactoringState.dart: upgradedStateto dart 2.17TaxonomyQueryConfiguration.dart: minor refactoringUriHelper.dart: minor refactoringWhat
enums to dart 2.17enums are still written in the old-fashioned way, they can be processed later if needed, but now the bulk ofenums have migrated. Or is it "are migrated"? Maybe both, whatever.Fixes bug(s)