Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

It should be possible to extract ingredients without taking a new photo #1377

Closed
Tracked by #107
teolemon opened this issue Mar 28, 2022 · 4 comments · Fixed by #1644
Closed
Tracked by #107

It should be possible to extract ingredients without taking a new photo #1377

teolemon opened this issue Mar 28, 2022 · 4 comments · Fixed by #1644
Assignees
Labels
✏️ Contribution ✏️ Editing - ingredients 🎨 Mockup required 🎨 Mockups available Some mockups are available for this issue. Please check everything is ok before starting coding. 🎯 P1 🛣️ Road to scores The easier it is to get Nutri-Score, Eco-Score, the happier the users.
Milestone

Comments

@teolemon
Copy link
Member

What

  • It should be possible to extract ingredients without taking a new photo

Steps to reproduce the behavior

  1. Go to Dev Mode
  2. Enable ingredients extraction
  3. Go to a product and open ingredient extraction
  4. You can't extract ingredients again without taking a new photo
  5. You don't see existing ingredients

Expected behavior

  • The existing ingredients are visible, there's a clear button/Text saying that you can re-extract them and I'm clicking the button you can extract them again
  • same if we have a picture but the ingredients were never extracted out of it

Why

  • some people want to contribute without having the actual product in their hands

Part of

@teolemon teolemon added this to the V1 milestone Apr 11, 2022
@teolemon teolemon added 🎯 P1 🛣️ Road to scores The easier it is to get Nutri-Score, Eco-Score, the happier the users. 🎨 Mockups available Some mockups are available for this issue. Please check everything is ok before starting coding. labels Apr 11, 2022
@teolemon
Copy link
Member Author

Extract ingredients

@cli1005 cli1005 self-assigned this Apr 21, 2022
@cli1005

This comment was marked as outdated.

@cli1005
Copy link
Contributor

cli1005 commented Apr 25, 2022

BEFORE:

  • Button "REFRESH" :
    1. Retake a new photo and upload it as new ingredients photo
    2. Extract text from this photo
    3. Update ingredients text of the products.
  • Button "CONFIRM" : Update ingredients text of the products.

AFTER:

  • Button "Refresh photo" :
    1. Retake a new photo and upload it as new ingredients photo
    2. Extract text from the photo(no saving)
  • Button "Extract ingredients" : Extract text from this current photo (no saving)
  • Button "Save" :
    1. Update ingredients text of the products.
    2. Refresh product page
  • Button "Cancel" : Back to the page Product (same as Back button < )

Snapshot:

BEFORE AFTER
Simulator Screen Shot - iPhone 13 - 2022-04-25 at 10 19 12 Simulator Screen Shot - iPhone 13 - 2022-04-25 at 12 37 57

@teolemon
Copy link
Member Author

@cli1005 Very clean, and better than the mockup 👌

cli1005 added a commit to cli1005/smooth-app that referenced this issue Apr 25, 2022
cli1005 added a commit to cli1005/smooth-app that referenced this issue Apr 25, 2022
cli1005 added a commit to cli1005/smooth-app that referenced this issue Apr 25, 2022
cli1005 added a commit to cli1005/smooth-app that referenced this issue Apr 25, 2022
@teolemon teolemon linked a pull request Apr 26, 2022 that will close this issue
cli1005 added a commit to cli1005/smooth-app that referenced this issue Apr 27, 2022
cli1005 added a commit to cli1005/smooth-app that referenced this issue Apr 27, 2022
cli1005 added a commit that referenced this issue Apr 27, 2022
* feat: #1377 - display and re-extract ingredients
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
✏️ Contribution ✏️ Editing - ingredients 🎨 Mockup required 🎨 Mockups available Some mockups are available for this issue. Please check everything is ok before starting coding. 🎯 P1 🛣️ Road to scores The easier it is to get Nutri-Score, Eco-Score, the happier the users.
Development

Successfully merging a pull request may close this issue.

2 participants