-
-
Notifications
You must be signed in to change notification settings - Fork 274
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: #2169 - new simple input page for "Stores" #2195
Conversation
New files: * `simple_input_page.dart`: Simple input page: we have a list of labels, we add, we remove, we save. * `simple_input_page_helpers.dart`: Helpers for Simple Input Page. Impacted files: * `category_picker_page.dart`: refactored * `edit_ingredients_page.dart`: refactored * `edit_product_page.dart`: added an "edit store" button; refactored * `nutrition_page_loaded.dart`: refactored * `product_query.dart`: added fields for stores * `product_refresher.dart`: now we return the saved and refreshed product instead of a mere bool
Codecov Report
@@ Coverage Diff @@
## develop #2195 +/- ##
==========================================
- Coverage 8.86% 7.86% -1.00%
==========================================
Files 161 180 +19
Lines 6623 8837 +2214
==========================================
+ Hits 587 695 +108
- Misses 6036 8142 +2106
Continue to review full report at Codecov.
|
That's really great @monsieurtanuki 👍 🎊 |
The very strong next candidates are labels since they are paramount for Eco-Score |
@teolemon Labels and tags both already have a meaning in off-dart. "terms" instead of "labels"? About "your" labels, isn't there a limited list of labels we could play with instead of typing them (which made sense for stores). I remember 2 different things:
Which list should we implement? |
One of the Open Food Facts principles is that we taxonomize based on popularity. Free-form input is a way to learn about new interesting labels we don't know about (like "Médaille d'or Concours 2020 de la Tripe") and if they are popular enough, add them in taxonomies. So #524 is not the way to go for this implementation, but might be for a future very optimized Eco-Score pipeline. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, thanks @monsieurtanuki
It will reset for products with no nutrition facts, but so will nutrition input @monsieurtanuki |
New files:
simple_input_page.dart
: Simple input page: we have a list of labels, we add, we remove, we save.simple_input_page_helpers.dart
: Helpers for Simple Input Page.Impacted files:
category_picker_page.dart
: refactorededit_ingredients_page.dart
: refactorededit_product_page.dart
: added an "edit store" button; refactorednutrition_page_loaded.dart
: refactoredproduct_query.dart
: added field for storesproduct_refresher.dart
: now we return the saved and refreshed product instead of a merebool
What
Screenshot
Added a "Stores" button in the detailed edit page:
Exiting the page after changes:
Part of