Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: #1538 - new crop tool (cf. dev mode) #2872

Merged
merged 6 commits into from
Sep 7, 2022

Commits on Aug 30, 2022

  1. fix: openfoodfacts#1538 - new crop tool (cf. dev mode)

    New files:
    * `crop_grid.dart`: heavily inspired from package `crop_image` - ideally we should put it back there.
    * `crop_helper.dart`: Crop Helper - which crop tool do we use, and the method to use it.
    * `new_crop_page.dart`: Page dedicated to image cropping. Pops the resulting file path if relevant.
    * `rotated_crop_controller.dart`: heavily inspired from package `crop_image` BUT with the rotation feature - ideally we should put it back there.
    * `rotated_crop_image.dart`: heavily inspired from package `crop_image` BUT with the rotation feature - ideally we should put it back there.
    * `rotation.dart`: 90 degree rotations - ideally we should put it back in package `crop_image`
    
    Impacted files:
    * `image_crop_page.dart`: now relying on new class `CropHelper` in order to get the appropriate crop tool (e.g. old or new)
    * `pubspec.lock`: wtf
    * `pubspec.yaml`: added package `image` for good performances regarding image encoding
    * `user_preferences_dev_mode.dart`: added a "Use new crop tool" switch (default is `false`)
    monsieurtanuki committed Aug 30, 2022
    Configuration menu
    Copy the full SHA
    33ba5d1 View commit details
    Browse the repository at this point in the history

Commits on Sep 4, 2022

  1. Configuration menu
    Copy the full SHA
    baf8a8c View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    f110417 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    6c4200b View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    c0620f6 View commit details
    Browse the repository at this point in the history

Commits on Sep 6, 2022

  1. Configuration menu
    Copy the full SHA
    e03f062 View commit details
    Browse the repository at this point in the history