Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: 4423 - specific "Not connected to internet" displayed error #4455

Merged
merged 14 commits into from
Aug 16, 2023

Commits on Aug 5, 2023

  1. feat: 4423 - specific "Not connected to internet" displayed error

    Impacted files:
    * `barcode_product_query.dart`: removed useless `try` as already `catch`'ed
    * `continuous_scan_model.dart`: removed the `codeInvalid` case that could never happen
    * `fetched_product.dart`: refactored with explicit constructors and additional exception and connectivity fields; removed the `codeInvalid` case that could never happen
    * `new_product_page.dart`: minor refactoring
    * `product_dialog_helper.dart`: removed the `codeInvalid` case that could never happen; minor refactoting
    * `product_list_item_simple.dart`: removed the `codeInvalid` case that could never happen
    * `product_loader_page.dart`: removed useless `try` as already `catch`'ed
    * `product_refresher.dart`: added a specific "You're not connected to the internet" error message; refactored using more `FetchedProduct`; removed useless method
    * `pubspec.lock`: wtf
    * `pubspec.yaml`: added package `connectivity_plus`
    * `question_card.dart`: refactored using `FetchedProduct`
    monsieurtanuki committed Aug 5, 2023
    Configuration menu
    Copy the full SHA
    2bdc0cd View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    0140427 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    e656cd3 View commit details
    Browse the repository at this point in the history

Commits on Aug 6, 2023

  1. feat: 4423 - new "server down" message after a ping attempt

    Impacted files:
    * `fetched_product.dart`: added field `failedPingedHost` where we store the host that we couldn't ping
    * `generated_plugin_registrant.cc`: wtf
    * `generated_plugins.cmake`: wtf
    * `GeneratedPluginRegistrant.swift`: wtf
    * `main.dart`: registered `DartPingIOS`
    * `product_refresher.dart`: now trying to ping the server if exception and connection
    * `pubspec.lock`: wtf
    * `pubspec.yaml: added packages `dart_ping` and `dart_ping_ios`
    monsieurtanuki committed Aug 6, 2023
    Configuration menu
    Copy the full SHA
    e6776cf View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    7bec563 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    d9e25ed View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    10cf906 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    da47152 View commit details
    Browse the repository at this point in the history

Commits on Aug 12, 2023

  1. Configuration menu
    Copy the full SHA
    2ba8c11 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    3226811 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    bf2db25 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    477144e View commit details
    Browse the repository at this point in the history

Commits on Aug 15, 2023

  1. Configuration menu
    Copy the full SHA
    cdecb93 View commit details
    Browse the repository at this point in the history

Commits on Aug 16, 2023

  1. feat: 4423 - localizations

    Impacted files:
    * `app_en.arb`: 4 new labels when we couldn't retrieve a product (not found, no internet, server down, server error)
    * `product_refresher.dart`: used the new labels
    monsieurtanuki committed Aug 16, 2023
    Configuration menu
    Copy the full SHA
    985440a View commit details
    Browse the repository at this point in the history