-
-
Notifications
You must be signed in to change notification settings - Fork 275
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: 4423 - specific "Not connected to internet" displayed error #4455
Merged
monsieurtanuki
merged 14 commits into
openfoodfacts:develop
from
monsieurtanuki:feat/4423
Aug 16, 2023
Merged
feat: 4423 - specific "Not connected to internet" displayed error #4455
monsieurtanuki
merged 14 commits into
openfoodfacts:develop
from
monsieurtanuki:feat/4423
Aug 16, 2023
Commits on Aug 5, 2023
-
feat: 4423 - specific "Not connected to internet" displayed error
Impacted files: * `barcode_product_query.dart`: removed useless `try` as already `catch`'ed * `continuous_scan_model.dart`: removed the `codeInvalid` case that could never happen * `fetched_product.dart`: refactored with explicit constructors and additional exception and connectivity fields; removed the `codeInvalid` case that could never happen * `new_product_page.dart`: minor refactoring * `product_dialog_helper.dart`: removed the `codeInvalid` case that could never happen; minor refactoting * `product_list_item_simple.dart`: removed the `codeInvalid` case that could never happen * `product_loader_page.dart`: removed useless `try` as already `catch`'ed * `product_refresher.dart`: added a specific "You're not connected to the internet" error message; refactored using more `FetchedProduct`; removed useless method * `pubspec.lock`: wtf * `pubspec.yaml`: added package `connectivity_plus` * `question_card.dart`: refactored using `FetchedProduct`
Configuration menu - View commit details
-
Copy full SHA for 2bdc0cd - Browse repository at this point
Copy the full SHA 2bdc0cdView commit details -
Configuration menu - View commit details
-
Copy full SHA for 0140427 - Browse repository at this point
Copy the full SHA 0140427View commit details -
Configuration menu - View commit details
-
Copy full SHA for e656cd3 - Browse repository at this point
Copy the full SHA e656cd3View commit details
Commits on Aug 6, 2023
-
feat: 4423 - new "server down" message after a ping attempt
Impacted files: * `fetched_product.dart`: added field `failedPingedHost` where we store the host that we couldn't ping * `generated_plugin_registrant.cc`: wtf * `generated_plugins.cmake`: wtf * `GeneratedPluginRegistrant.swift`: wtf * `main.dart`: registered `DartPingIOS` * `product_refresher.dart`: now trying to ping the server if exception and connection * `pubspec.lock`: wtf * `pubspec.yaml: added packages `dart_ping` and `dart_ping_ios`
Configuration menu - View commit details
-
Copy full SHA for e6776cf - Browse repository at this point
Copy the full SHA e6776cfView commit details -
Configuration menu - View commit details
-
Copy full SHA for 7bec563 - Browse repository at this point
Copy the full SHA 7bec563View commit details -
Configuration menu - View commit details
-
Copy full SHA for d9e25ed - Browse repository at this point
Copy the full SHA d9e25edView commit details -
Configuration menu - View commit details
-
Copy full SHA for 10cf906 - Browse repository at this point
Copy the full SHA 10cf906View commit details -
Configuration menu - View commit details
-
Copy full SHA for da47152 - Browse repository at this point
Copy the full SHA da47152View commit details
Commits on Aug 12, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 2ba8c11 - Browse repository at this point
Copy the full SHA 2ba8c11View commit details -
Configuration menu - View commit details
-
Copy full SHA for 3226811 - Browse repository at this point
Copy the full SHA 3226811View commit details -
Configuration menu - View commit details
-
Copy full SHA for bf2db25 - Browse repository at this point
Copy the full SHA bf2db25View commit details -
Configuration menu - View commit details
-
Copy full SHA for 477144e - Browse repository at this point
Copy the full SHA 477144eView commit details
Commits on Aug 15, 2023
-
Configuration menu - View commit details
-
Copy full SHA for cdecb93 - Browse repository at this point
Copy the full SHA cdecb93View commit details
Commits on Aug 16, 2023
-
Impacted files: * `app_en.arb`: 4 new labels when we couldn't retrieve a product (not found, no internet, server down, server error) * `product_refresher.dart`: used the new labels
Configuration menu - View commit details
-
Copy full SHA for 985440a - Browse repository at this point
Copy the full SHA 985440aView commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.