Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Popup Menu now uses the iOS actions sheet #5494

Merged
merged 3 commits into from
Jul 22, 2024

Conversation

g123k
Copy link
Collaborator

@g123k g123k commented Jul 20, 2024

Hi everyone,

We have a "three dots" menu item containing actions on the screen with lists.
On Android, we use the PopupMenuButton from Material, but on iOS, it looks really… Android.

I've created a custom Widget that shows the Cupertino component on iOS and macOS. Otherwise, it's Material.

Android:
Screenshot 2024-07-20 at 03 14 16

iOS:
Screenshot 2024-07-20 at 03 13 54

(cherry picked from commit 493f3d2)
@g123k g123k requested a review from a team as a code owner July 20, 2024 01:20
@g123k g123k self-assigned this Jul 20, 2024
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 0% with 70 lines in your changes missing coverage. Please review.

Project coverage is 7.14%. Comparing base (4d9c7fc) to head (db039f9).
Report is 251 commits behind head on develop.

Files Patch % Lines
...ges/smooth_app/lib/widgets/smooth_menu_button.dart 0.00% 48 Missing ⚠️
.../product/common/product_list_item_popup_items.dart 0.00% 7 Missing ⚠️
...pages/product/common/product_list_popup_items.dart 0.00% 7 Missing ⚠️
...mooth_app/lib/pages/personalized_ranking_page.dart 0.00% 4 Missing ⚠️
...pp/lib/pages/product/common/product_list_page.dart 0.00% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           develop   #5494      +/-   ##
==========================================
- Coverage     9.54%   7.14%   -2.41%     
==========================================
  Files          325     392      +67     
  Lines        16411   20458    +4047     
==========================================
- Hits          1567    1462     -105     
- Misses       14844   18996    +4152     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@teolemon teolemon added the 🍎 iOS iOS specific issues or PRs label Jul 20, 2024
Copy link
Member

@teolemon teolemon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice touch. I reckon iOS doesn't allow icons in the bottom sheet, and that the font will look slightly different from the emulator.

@g123k
Copy link
Collaborator Author

g123k commented Jul 22, 2024

Thanks for your feedback @teolemon!

@g123k g123k merged commit a9e216c into openfoodfacts:develop Jul 22, 2024
6 checks passed
@g123k g123k deleted the smooth_popup branch July 22, 2024 08:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

3 participants