feature/#21 - automatically storing keywords and group results into the database #71
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…he database ... and automagically asking the end-user if they want to see the cache New files: * `dao_product.dart` * `dao_product_list.dart` * `database_product_list_supplier.dart` * `product_list.dart` * `product_list_supplier.dart` * `product_query_page_helper.dart` * `query_product_list_supplier.dart` Impacted files: * `choose_page.dart`: now uses `ProductQueryPageHelper` in order to get database or http results; refactored * `continuous_scan_model.dart`: minor refactoring due to DAO * `group_product_query.dart`: now implements new method `getProductList` * `keywords_product_query.dart`: now implements new method `getProductList` * `local_database.dart`: now it's version 2; refactored using the new DAO classes * `product_query.dart`: new method `getProductList` * `product_query_model.dart`: now we use a `ProductListSupplier` instead of a `ProductQuery` * `product_query_page.dart`: now we use a `ProductListSupplier` instead of a `ProductQuery`
monsieurtanuki
requested review from
stephanegigandet,
PrimaelQuemerais and
M123-dev
M123-dev
approved these changes
Jan 11, 2021
|
Thank you @M123-dev! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
... and automagically asking the end-user if they want to see the cache
New files:
dao_product.dartdao_product_list.dartdatabase_product_list_supplier.dartproduct_list.dartproduct_list_supplier.dartproduct_query_page_helper.dartquery_product_list_supplier.dartImpacted files:
choose_page.dart: now usesProductQueryPageHelperin order to get database or http results; refactoredcontinuous_scan_model.dart: minor refactoring due to DAOgroup_product_query.dart: now implements new methodgetProductListkeywords_product_query.dart: now implements new methodgetProductListlocal_database.dart: now it's version 2; refactored using the new DAO classesproduct_query.dart: new methodgetProductListproduct_query_model.dart: now we use aProductListSupplierinstead of aProductQueryproduct_query_page.dart: now we use aProductListSupplierinstead of aProductQueryAs mentioned, for the moment I've only implemented the list for keywords and group searches:
