Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Children and new node id should be normalized in the backend #79

Closed
alexgarel opened this issue Sep 13, 2022 · 2 comments · Fixed by #111
Closed

Children and new node id should be normalized in the backend #79

alexgarel opened this issue Sep 13, 2022 · 2 comments · Fixed by #111
Assignees
@aerial-ace1
Labels
🐛 bug Something isn't working hacktoberfest osd'22

Comments

@alexgarel
Copy link
Member

We have an API to add an entry or add children introduced by #76

This API do not currently normalize the tag used as ID, it should.

Normalization function is currently in the Parser. If possible it should be moved to a utility function and called from the backend to normalize received id.
@alexgarel alexgarel added 🐛 bug Something isn't working osd'22 labels Sep 13, 2022
@aadarsh-ram aadarsh-ram mentioned this issue Sep 13, 2022
Closed
@aerial-ace1
Copy link
Contributor

Can I work on this issue?

@aadarsh-ram
Copy link
Collaborator

@aerial-ace1 Please do! I'll assign this issue to you.

@aerial-ace1 aerial-ace1 mentioned this issue Oct 11, 2022
Merged
alexgarel pushed a commit that referenced this issue Oct 19, 2022
@aerial-ace1
fix: Normalising Children and New Nodes (#111)
118a60f 
Code added normalises the nodes using the normalising function in the API calls of:
* Created
* Updated Nodes
* Updated Nodes Children

Fixes #79 (Children and new node id should be normalized in the backend)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@aerial-ace1 aerial-ace1

Labels
🐛 bug Something isn't working hacktoberfest osd'22
Projects
No open projects
🧬 Taxonomy editor - gsoc 2022
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: Normalising Children and New Nodes aerial-ace1/taxonomy-editor
3 participants
@alexgarel @aadarsh-ram @aerial-ace1