Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Changed JSON according to spec #19

Merged
merged 10 commits into from
Jul 20, 2022
Merged

fix: Changed JSON according to spec #19

merged 10 commits into from
Jul 20, 2022

Conversation

aadarsh-ram
Copy link
Collaborator

What

  • Changed JSON schema and sample JSON according to spec

@aadarsh-ram aadarsh-ram requested a review from a team as a code owner July 16, 2022 12:41
alexgarel
alexgarel reviewed Jul 18, 2022
View reviewed changes
Copy link
Member

@alexgarel alexgarel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some comments !

I think it would be even more important to have a file that we could import in neo4j. I don't know if you took some time to look at it already ?

backend/sample/schema.json Outdated Show resolved Hide resolved
backend/sample/schema.json Outdated Show resolved Hide resolved
backend/sample/schema.json Outdated Show resolved Hide resolved
backend/sample/schema.json Outdated Show resolved Hide resolved
backend/sample/schema.json Outdated Show resolved Hide resolved
backend/sample/schema.json Show resolved Hide resolved
backend/sample/test.json Show resolved Hide resolved
@aadarsh-ram
Copy link
Collaborator Author

I think it would be even more important to have a file that we could import in neo4j. I don't know if you took some time to look at it already ?

Do you mean an importable schema? I researched and found that a direct "data model" (in Neo4j terms) can't be imported from a file. So, I think that the creation of each node and relationship must be done through the parser (that's been already implemented).

alexgarel
alexgarel reviewed Jul 20, 2022
View reviewed changes
backend/sample/test.json Outdated Show resolved Hide resolved
@aadarsh-ram
Copy link
Collaborator Author

aadarsh-ram commented Jul 20, 2022 •
edited
Loading

@alexgarel I hope all changes except the "previous_entry" and "next_entry" properties addition has been addressed. Once the spec has been updated, I'll go through it and change both the schema and JSON appropriately.

alexgarel
alexgarel reviewed Jul 20, 2022
View reviewed changes
Copy link
Member

@alexgarel alexgarel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@aadarsh-ram let's merge.

On my side I will do a PR with:

  • a neo4j importable file
  • spec update
  • eventual update to those files

@alexgarel alexgarel merged commit 9133a70 into main Jul 20, 2022
@alexgarel alexgarel deleted the json-change branch July 20, 2022 13:43
@openfoodfacts-bot openfoodfacts-bot mentioned this pull request Dec 1, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexgarel alexgarel alexgarel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
No open projects
🧬 Taxonomy editor - gsoc 2022
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aadarsh-ram @alexgarel