feat(frontend): make language selection for translations more intuitive #461
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
March 20, 2024 19:13
… or xx is not the main language, only display message about changing first translation if lang was not empty)
… translations more intuitive
Piv94165
approved these changes
Mar 27, 2024
There was a problem hiding this comment.
Great PR!
Everything seems to be functioning smoothly from my end. One thing I might suggest is consulting with taxonomy experts regarding the naming convention for fallback languages, as Alizarine mentioned that she wasn't sure to understand the term. However, this can be addressed in a separate PR.
One minor issue I noticed is a peculiar behavior: when we display all existing languages, pin one from the list, and then hide it, it doesn't disappear (presumably because all existing languages are checked). Perhaps there's a better approach to handling this scenario. Nevertheless, I don't consider it critical enough to block the PR.
Great work overall!
|
Tested ok ! |
perierc
added a commit
that referenced
this pull request
Apr 11, 2024
* feat(frontend): make language selection for translations more intuitive (#461) The PR modifies the translations section of the edit entry page: * Changes "All languages" terminology to "Fallback translations" (fixes #458) * Adds an info alert if "en" (English) or "xx" (Fallback translations) is not the main language for an entry (fixes #457) / Fixes the fact that the alert message about changing the display name of a language appears even if the language had no translations and we add the first one (fixes #459) * Adds a "Show all existing translations" checkbox to see all the languages that currently have translations, with their translations Adds a possibility to "pin" languages to select them (so they stay in local storage and appear at the top for each entry), and a possibility to hide (unselect) these languages easily (with an icon next to their title) * Modifies the selection of new languages: I removed the "number of languages shown" button that had to be clicked to add a language, and created a "Show another language" button at the bottom of the section. Also, the dialog is now an autocomplete instead of a select, and you just type the languages that you want to add and see languages that are not selected, instead of seeing all current languages and being able to remove them. The autocomplete with the options is also automatically focused when opening the dialog. * Adds vite-plugin-svgr to easily import svg files in React --------- Co-authored-by: Charles Perier <charlesperier@Charless-Laptop.local> * feat: add property filter to search API (#456) * feat: add property filter to search API * chore: generate SDK * chore: Add info banners on the frontend (#473) * docs: add info banners * refactor: delete unnecessary components * fix: add line break * improve search results, and few other improvements * show translations instead of translated languages --------- Co-authored-by: Charles Perier <charlesperier@Charless-Laptop.local> Co-authored-by: Eric Nguyen <ericnguyen.developper@gmail.com>
Piv94165
added a commit
that referenced
this pull request
Apr 11, 2024
* working on component querying backend * feat(frontend): link advanced research component with backend * feat(frontend): add parent, child, ancestor, descendant filter * feat(frontend): disable modified filter with comment * feat(frontend): add search results with pagination * feat(frontend): search expression is refactored by backend * refactor(frontend): replace search page, avoid useeffect and many rerenders * refactor(frontend): a file for each main component * feat(frontend): is:external and is:not:external filter * feat(frontend): add external filter * refactor(frontend): clean code, add error message if needed * lint * refactor(frontend): change multiple select filter behaviour * refactor(frontend): remove useless states and props * feat(frontend): unify design with select and inputs components only * refactor(frontend): refactor singleSelectFilter * feat: improve search results display (#484) * feat(frontend): make language selection for translations more intuitive (#461) The PR modifies the translations section of the edit entry page: * Changes "All languages" terminology to "Fallback translations" (fixes #458) * Adds an info alert if "en" (English) or "xx" (Fallback translations) is not the main language for an entry (fixes #457) / Fixes the fact that the alert message about changing the display name of a language appears even if the language had no translations and we add the first one (fixes #459) * Adds a "Show all existing translations" checkbox to see all the languages that currently have translations, with their translations Adds a possibility to "pin" languages to select them (so they stay in local storage and appear at the top for each entry), and a possibility to hide (unselect) these languages easily (with an icon next to their title) * Modifies the selection of new languages: I removed the "number of languages shown" button that had to be clicked to add a language, and created a "Show another language" button at the bottom of the section. Also, the dialog is now an autocomplete instead of a select, and you just type the languages that you want to add and see languages that are not selected, instead of seeing all current languages and being able to remove them. The autocomplete with the options is also automatically focused when opening the dialog. * Adds vite-plugin-svgr to easily import svg files in React --------- Co-authored-by: Charles Perier <charlesperier@Charless-Laptop.local> * feat: add property filter to search API (#456) * feat: add property filter to search API * chore: generate SDK * chore: Add info banners on the frontend (#473) * docs: add info banners * refactor: delete unnecessary components * fix: add line break * improve search results, and few other improvements * show translations instead of translated languages --------- Co-authored-by: Charles Perier <charlesperier@Charless-Laptop.local> Co-authored-by: Eric Nguyen <ericnguyen.developper@gmail.com> * refactor(frontend): remove useless lines, add css * rewording * test --------- Co-authored-by: alice.juan <alice.juan@student-cs.fr> Co-authored-by: Charles Perier <82757576+perierc@users.noreply.github.com> Co-authored-by: Charles Perier <charlesperier@Charless-Laptop.local> Co-authored-by: Eric Nguyen <ericnguyen.developper@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
The PR modifies the translations section of the edit entry page:
vite-plugin-svgrto easily importsvgfiles in ReactScreenshot
Screen.Recording.2024-03-22.at.11.51.34.mov
Part of