Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Error while updating a node (backend) #74

Merged
merged 6 commits into from
Sep 7, 2022
Merged

fix: Error while updating a node (backend) #74

merged 6 commits into from
Sep 7, 2022

Conversation

aadarsh-ram
Copy link
Collaborator

What

  • Accessing key-value pairs was implemented wrongly in the update function
  • Two separate variables, one for keys and a dictionary for all data of the node has been created

@aadarsh-ram aadarsh-ram requested a review from a team as a code owner September 7, 2022 03:34
@aadarsh-ram aadarsh-ram changed the title fix: Error while updating a node fix: Error while updating a node (backend) Sep 7, 2022
alexgarel
alexgarel approved these changes Sep 7, 2022
View reviewed changes
Copy link
Member

@alexgarel alexgarel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alexgarel alexgarel merged commit f24ff83 into main Sep 7, 2022
@alexgarel alexgarel deleted the fixupdatebackend branch September 7, 2022 09:38
@openfoodfacts-bot openfoodfacts-bot mentioned this pull request Dec 1, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexgarel alexgarel alexgarel approved these changes

Assignees

@aadarsh-ram aadarsh-ram

Labels
None yet
Projects
No open projects
🧬 Taxonomy editor - gsoc 2022
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aadarsh-ram @alexgarel