chore: log channel provider message id to aid debugging #1951

jhibberd-gov · 2023-03-03T03:54:32Z

Task:
https://www.notion.so/opengov/Ensure-AWS-SES-message_id-are-logged-with-table-primary-key-ID-03254019c59f4a6d92af62a11043c6fc

Solution

Message AWS SES ID written to CloudWatch Logs alongside "native" message ID (i.e. DB table primary key value).
Tested in staging (both campaign and tx).
Wrote guide on how to resolve AWS SES ID from native message ID.
Confirmed both log groups have sufficient retention (currently infinite).

backend/src/core/services/auth.service.ts

backend/src/email/services/email.service.ts

shared/src/clients/mail-client.class/index.ts

zxt-tzx · 2023-03-06T12:55:34Z

lgtm mostly just nits!

zxt-tzx

lgtm

backend/src/core/services/auth.service.ts

backend/src/email/services/email.service.ts

chore: log channel provider message id to aid debugging

32604a8

jhibberd-gov requested review from stanleynguyen, zxt-tzx and richard-yak March 3, 2023 06:33

zxt-tzx suggested changes Mar 6, 2023

View reviewed changes

backend/src/core/services/auth.service.ts Outdated Show resolved Hide resolved

backend/src/email/services/email.service.ts Outdated Show resolved Hide resolved

shared/src/clients/mail-client.class/index.ts Outdated Show resolved Hide resolved

chore: addressed nits from review

ac14a1c

zxt-tzx approved these changes Mar 7, 2023

View reviewed changes

backend/src/core/services/auth.service.ts Outdated Show resolved Hide resolved

backend/src/core/services/auth.service.ts Outdated Show resolved Hide resolved

backend/src/email/services/email.service.ts Outdated Show resolved Hide resolved

jhibberd-gov and others added 2 commits March 7, 2023 13:13

chore: addressed nits from review (2)

20d9c1b

Merge branch 'master' into refactor/log-ses-msg-id

8e34958

jhibberd-gov merged commit 3cc6035 into master Mar 7, 2023

jhibberd-gov deleted the refactor/log-ses-msg-id branch March 7, 2023 05:40

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chore: log channel provider message id to aid debugging #1951

chore: log channel provider message id to aid debugging #1951

jhibberd-gov commented Mar 3, 2023

zxt-tzx commented Mar 6, 2023

zxt-tzx left a comment

chore: log channel provider message id to aid debugging #1951

chore: log channel provider message id to aid debugging #1951

Conversation

jhibberd-gov commented Mar 3, 2023

Solution

zxt-tzx commented Mar 6, 2023

zxt-tzx left a comment

Choose a reason for hiding this comment