-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[mikrotik] Add PoE support #17351
base: main
Are you sure you want to change the base?
[mikrotik] Add PoE support #17351
Conversation
asp24
commented
Aug 30, 2024
- [Improvement] Implemented PoE monitoring and contol
- [FIX] Crash on some routers with high available RAM available
- [FIX] Modern WiFI impl packages registrations tables polling
19df9ff
to
2f78cb9
Compare
Signed-off-by: asp24 <488588+asp24@users.noreply.github.com>
Implemented polling Wireless and Capsman registrations tables from all known mikrotik wifi impl Signed-off-by: asp24 <488588+asp24@users.noreply.github.com>
…style Signed-off-by: asp24 <488588+asp24@users.noreply.github.com>
Signed-off-by: asp24 <488588+asp24@users.noreply.github.com>
Signed-off-by: asp24 <488588+asp24@users.noreply.github.com>
Signed-off-by: asp24 <488588+asp24@users.noreply.github.com>
Signed-off-by: asp24 <488588+asp24@users.noreply.github.com>
2f78cb9
to
dc31c0f
Compare
Would it be possible to split the bugfix and the enhancement? If it is too much of a hassle its fine, but smaller/ dedicated PR.s are simpler to review, backport and also show up independend in the release notes |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks. Besides the minor comments, it would be needed to provide thing upgrade instructions for the added channels.
For referece: https://www.openhab.org/docs/developer/bindings/thing-xml.html#updating-thing-types
Oh, when the labels are adjusted the i18n plugin has to be re-run to update the properties file.
...nding.mikrotik/src/main/java/org/openhab/binding/mikrotik/internal/model/RouterosDevice.java
Show resolved
Hide resolved
...nding.mikrotik/src/main/java/org/openhab/binding/mikrotik/internal/model/RouterosDevice.java
Outdated
Show resolved
Hide resolved
...rotik/src/main/java/org/openhab/binding/mikrotik/internal/model/RouterosRouterboardInfo.java
Show resolved
Hide resolved
bundles/org.openhab.binding.mikrotik/src/main/resources/OH-INF/thing/thing-types.xml
Outdated
Show resolved
Hide resolved
bundles/org.openhab.binding.mikrotik/src/main/resources/OH-INF/thing/thing-types.xml
Outdated
Show resolved
Hide resolved
bundles/org.openhab.binding.mikrotik/src/main/resources/OH-INF/thing/thing-types.xml
Outdated
Show resolved
Hide resolved
...c/main/java/org/openhab/binding/mikrotik/internal/handler/MikrotikInterfaceThingHandler.java
Outdated
Show resolved
Hide resolved
…/thing/thing-types.xml Co-authored-by: lsiepel <leosiepel@gmail.com> Signed-off-by: Yuriy <asp24@users.noreply.github.com>
Co-authored-by: lsiepel <leosiepel@gmail.com> Signed-off-by: Yuriy <asp24@users.noreply.github.com>
Co-authored-by: lsiepel <leosiepel@gmail.com> Signed-off-by: Yuriy <asp24@users.noreply.github.com>
Signed-off-by: asp24 <488588+asp24@users.noreply.github.com>
Signed-off-by: asp24 <488588+asp24@users.noreply.github.com>
Signed-off-by: asp24 <488588+asp24@users.noreply.github.com>
1d7bf83
to
e832c67
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some additional comments. Also run the i18n plugin to generate the labels etc
xsi:schemaLocation="https://openhab.org/schemas/update-description/v1.0.0 https://openhab.org/schemas/update-description-1.0.0.xsd"> | ||
|
||
<thing-type uid="mikrotik:routeros"> | ||
<instruction-set targetVersion="1"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The version also need to be added to the interface
Thing as property.
<properties>
<property name="thingTypeVersion">1</property>
</properties>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Only this comment is left ^^, not sure if you missed it
bundles/org.openhab.binding.mikrotik/src/main/resources/OH-INF/update/instructions.xml
Outdated
Show resolved
Hide resolved
Co-authored-by: lsiepel <leosiepel@gmail.com> Signed-off-by: Yuriy <asp24@users.noreply.github.com>
Signed-off-by: asp24 <488588+asp24@users.noreply.github.com>