Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix autoUpdatePolicy for write-only channels #17439

Closed
wants to merge 2 commits into from

Conversation

mlobstein
Copy link
Contributor

Correct the autoUpdatePolicy for all of the write-only channels in bindings for which I am the code owner.

Signed-off-by: Michael Lobstein <michael.lobstein@gmail.com>
Signed-off-by: Michael Lobstein <michael.lobstein@gmail.com>
Copy link
Contributor

@lsiepel lsiepel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM

As this PR changes the behaviour, this should be listed in the release notes. Therefore it would be berst to split the PR into seperate PR's per binding. wdyt?

@mlobstein
Copy link
Contributor Author

mlobstein commented Sep 20, 2024

Thanks, LGTM

As this PR changes the behaviour, this should be listed in the release notes. Therefore it would be berst to split the PR into seperate PR's per binding. wdyt?

I can go either way... It is such a minor change to have the autoUpdate policy implicitly set for these stateless channels that I thought I would try to do them all in one PR rather than all the noise that 9 individual PRs would cause.

@lsiepel
Copy link
Contributor

lsiepel commented Sep 20, 2024

@openhab/add-ons-maintainers wdyt?

@lsiepel lsiepel added the enhancement An enhancement or new feature for an existing add-on label Sep 22, 2024
@kaikreuzer
Copy link
Member

@lsiepel Would we consider it a breaking change? If so, we would have it in the distro's update.lst file, which would automatically warn the users.
But I don't really think that it needs to be considered breaking; in that case, separate PRs might indeed be nice so that users of the respective bindings will find a message in the release notes that informs them about the enhancement.

@mlobstein
Copy link
Contributor Author

OK, I will create individual PRs instead.

@lsiepel
Copy link
Contributor

lsiepel commented Sep 23, 2024

@lsiepel Would we consider it a breaking change? If so, we would have it in the distro's update.lst file, which would automatically warn the users. But I don't really think that it needs to be considered breaking; in that case, separate PRs might indeed be nice so that users of the respective bindings will find a message in the release notes that informs them about the enhancement.

I would not consider this a breaking change

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement An enhancement or new feature for an existing add-on
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants