Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[icalendar] Add useragent parameter #17455

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

lsiepel
Copy link
Contributor

@lsiepel lsiepel commented Sep 21, 2024

Some providers take weird security measures requiring user to alter their user agent string.
This PR adds a userAgent parameter that (when not set or empty) falls back to default jetty's user agent header.

Resolves: #17392

Test jar (4.3.0): https://1drv.ms/u/s!AnMcxmvEeupwj4cux4uohlY6tjZwIA?e=S476t0

Signed-off-by: Leo Siepel <leosiepel@gmail.com>
@lsiepel lsiepel added enhancement An enhancement or new feature for an existing add-on additional testing preferred The change works for the pull request author. A test from someone else is preferred though. labels Sep 21, 2024
@lsiepel lsiepel requested a review from a team as a code owner September 21, 2024 12:31
@lsiepel lsiepel changed the title [icalendar ]Add useragent parameter [icalendar] Add useragent parameter Sep 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
additional testing preferred The change works for the pull request author. A test from someone else is preferred though. enhancement An enhancement or new feature for an existing add-on
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[icalendar] Add User-Agent property for iCalendar binding
1 participant