Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[modbus] Discard data if transformation failed #17457

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[modbus] Discard data if transformation failed #17457

wants to merge 1 commit into from

Conversation

jimtng
Copy link
Contributor

@jimtng jimtng commented Sep 22, 2024

Resolve #16847

@jimtng
[modbus] Discard data if transformation failed
6b5c94a 
Signed-off-by: Jimmy Tanagra <jcode@tanagra.id.au>
@jimtng jimtng mentioned this pull request Sep 22, 2024
Open
@jimtng
Copy link
Contributor Author

jimtng commented Sep 22, 2024

If someone can test this, you can use this jar (renamed to .txt)

org.openhab.binding.modbus-4.3.0-SNAPSHOT.jar.txt

ssalonen
ssalonen approved these changes Sep 22, 2024
View reviewed changes
Copy link
Contributor

@ssalonen ssalonen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@lsiepel lsiepel added enhancement An enhancement or new feature for an existing add-on additional testing preferred The change works for the pull request author. A test from someone else is preferred though. labels Sep 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ssalonen ssalonen ssalonen approved these changes

Assignees
No one assigned
Labels
additional testing preferred The change works for the pull request author. A test from someone else is preferred though. enhancement An enhancement or new feature for an existing add-on
Projects
None yet
Milestone
No milestone
3 participants
@jimtng @ssalonen @lsiepel