Enhance: Update SDK and support split summary messages #115
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
muktihari
commented
Sep 23, 2024
muktihari
commented
- Previously, we discard split summary messages since we didn't how to properly combine it since if combine it incorrectly, the resulting file will be rejected by Garmin Connect. Now we know that this message should be unique for each split_type.
- Bump FIT SDK for Go to latest version.
muktihari
commented
Sep 23, 2024
Comment on lines
+68
to
+71
| mesg := a.SplitSummaries[i].ToMesg(nil) | ||
| mesg.Fields = append([]proto.Field{ | ||
| factory.CreateField(mesgnum.Session, fieldnum.SessionTimestamp).WithValue(datetime.ToUint32(a.Activity.Timestamp)), | ||
| }, mesg.Fields...) |
There was a problem hiding this comment.
We must add timestamp here, otherwise Garmin Connect rejects it as well. This is a bit weird since split_summary does not actually have defined timestamp, but FIT files produced by Garmin Device contains timestamp. But we don't have control over this, just follow their pattern.
raditzlawliet
changed the title
raditzlawliet
changed the title
raditzlawliet
changed the title
raditzlawliet
approved these changes
Sep 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.